Fix dir issues in comparing images #638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolution
main
#635Select one: This pull request is...
1. Does this do what we want it to do?
Objectives:
image_check_failures
directories weren't generating properly.main
#635 will be resolved elsewhere:main
#635 (comment), thelnd
issue will be resolved by Update to diags handling #633.lnd
issue. So, I will do that after Update to diags handling #633 merges.Required:
2. Are the implementation details accurate & efficient?
Required:
3. Is this well documented?
Required:
4. Is this code clean?
Required: