Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dir issues in comparing images #638

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Oct 28, 2024

Issue resolution

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

1. Does this do what we want it to do?

Objectives:

Required:

  • Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
  • Testing: I have added or modified at least one "min-case" configuration file to test this change. Every objective above is represented in at least one cfg.
  • This is specifically part of weekly testing.
  • Testing: I have considered likely and/or severe edge cases and have included them in testing.

2. Are the implementation details accurate & efficient?

Required:

  • Logic: I have visually inspected the entire pull request myself.
  • Logic: I have left GitHub comments highlighting important pieces of code logic. I have had these code blocks reviewed by at least one other team member.

3. Is this well documented?

Required:

  • Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.
  • This is non-user facing.

4. Is this code clean?

Required:

  • Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 marked this pull request as ready for review October 28, 2024 22:17
@forsyth2 forsyth2 added the Testing Files in `tests` modified label Oct 28, 2024
@forsyth2 forsyth2 merged commit 32428ef into main Oct 28, 2024
4 checks passed
@forsyth2 forsyth2 deleted the issue-635-compare-images branch October 28, 2024 22:17
zhangshixuan1987 pushed a commit to zhangshixuan1987/zppy that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Files in `tests` modified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Errors in 2024-10-25 test of main
1 participant