Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hackathon] Ionization docs fixes #5270

Merged
merged 4 commits into from
Sep 17, 2024
Merged

[Hackathon] Ionization docs fixes #5270

merged 4 commits into from
Sep 17, 2024

Conversation

johvandewetering
Copy link
Contributor

Fixed testing link for field ionization and fixed typos in kinetic-fluid docs

@ax3l ax3l added the component: documentation Docs, readme and manual label Sep 16, 2024
ax3l
ax3l reviewed Sep 16, 2024
View reviewed changes
Docs/source/theory/kinetic_fluid_hybrid_model.rst
@@ -46,7 +46,7 @@ integrating over velocity), also called the generalized Ohm's law, is given by:

.. math::

en_e\vec{E} = \frac{m}{e}\frac{\partial \vec{J}_e}{\partial t} + \frac{m}{e^2}\left( \vec{U}_e\cdot\nabla \right) \vec{J}_e - \nabla\cdot {\overleftrightarrow P}_e - \vec{J}_e\times\vec{B}+\vec{R}_e
en_e\vec{E} = \frac{m}{e}\frac{\partial \vec{J}_e}{\partial t} + \frac{m}{e}\left( \vec{U}_e\cdot\nabla \right) \vec{J}_e - \nabla\cdot {\overleftrightarrow P}_e - \vec{J}_e\times\vec{B}+\vec{R}_e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For @roelof-groenewald to double check :)

roelof-groenewald
roelof-groenewald approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@roelof-groenewald roelof-groenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the typos in the Ohm's model docs. I realized there are actually a few other sign errors (inconsistency in how $J_e$ is defined). I'll update those in a follow-up PR with some better variable naming in the Ohm's solver module.

@roelof-groenewald roelof-groenewald enabled auto-merge (squash) September 17, 2024 00:10
@roelof-groenewald roelof-groenewald merged commit f7dd6a9 into ECP-WarpX:development Sep 17, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l left review comments

@roelof-groenewald roelof-groenewald roelof-groenewald approved these changes

@n01r n01r Awaiting requested review from n01r

@RemiLehe RemiLehe Awaiting requested review from RemiLehe

Assignees

@roelof-groenewald roelof-groenewald

Labels
component: documentation Docs, readme and manual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johvandewetering @ax3l @roelof-groenewald