-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.13 Support, 3.8 EOL #5361
base: development
Are you sure you want to change the base?
Conversation
Add support for Python 3.13. Remove 3.8 because it is EOL as of Oct 2024.
setup.py
Outdated
@@ -301,7 +301,7 @@ def build_extension(self, ext): | |||
cmdclass=cmdclass, | |||
# scripts=['warpx_1d', 'warpx_2d', 'warpx_rz', 'warpx_3d'], | |||
zip_safe=False, | |||
python_requires=">=3.8", | |||
python_requires=">=3.8", # left for CI, truly ">=3.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this comment mean the CI uses Python 3.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, a few CI runners still use Python 3.8 and for me that is ok for now.
We can bump this once we update CI runners for 3.9+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I did a quick grep of $ git grep "python-version" .github/
.github/workflows/cuda.yml:30: python-version: '3.x'
.github/workflows/windows.yml:24: python-version: '3.x'
.github/workflows/windows.yml:75: python-version: '3.8' I think So maybe the only job that uses Python 3.8 is "Clang C++17 w/ OMP w/o MPI" in the "Windows" workflow: WarpX/.github/workflows/windows.yml Lines 67 to 119 in d0690e2
Do we want to try to upgrade this Python version directly in this PR, if Python 3.8 is EOL as of October 2024? |
There are a few more that use Ubuntu 20.04 without The way to update these would be to bump to 22.04 or, where we intentionally test an old compiler to ensure we can still use it (e.g., old NVCC that we specify as our minimum requirement), use |
Ah yes, and Azure runs on Ubuntu 20.04 and checksums are too strict: #5203 |
Add support for Python 3.13.
Remove 3.8 because it is EOL as of Oct 2024.
Bump to pybind11 2.13.0+, which add Python 3.13 support in CI.