-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Sidebar #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with PR @rajesh6161 the sidebar is awesome. I would like some changes as below:
- don't include unnecessary files for the PR like
.vscode/c_cpp_properties.json
- I suggest you use the Icons from the link whenever possible https://material-ui.com/components/material-icons/
src/components/SideDrawer/logo.png
should be extracted to assets- use class-based components and "no hooks".
I will remove unneccsary filse for you this time 😇 .
Okay sir I will follow along this guideline from next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be split into multiple files. But ok for now. Thought of doing it myself but on a time crunch for now. I will do that later.
Fixes #18
Description
Sidebar implemented by taking all the considerations.
Type of change
Screenshots of change:
Checklist:
Code/Quality Assurance