Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clobbering of overridden canvas methods #2658

Merged
merged 5 commits into from
Aug 17, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix browser detection in test
Should be able to figure out that "Google Chrome" is chrome
  • Loading branch information
STRML committed Jul 31, 2020
commit 165d12b55c8519c8555775dc35331885b9564b98
2 changes: 1 addition & 1 deletion tests/selenium/pbtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def unix_which(command, silent=False):

def get_browser_type(string):
for t in BROWSER_TYPES:
if t in string:
if t in string.lower():
return t
raise ValueError("couldn't get browser type from %s" % string)

Expand Down