Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify row presolve #2190

Merged
merged 11 commits into from
Feb 25, 2025
Merged

Simplify row presolve #2190

merged 11 commits into from
Feb 25, 2025

Conversation

fwesselm
Copy link
Collaborator

  • Reduce amount of similar / duplicate code in HPresolve::rowPresolve().
  • Ran 850+ MIPs, only two instances show a minor change in the node counts. The overall performance in terms of relative shifted geometric means is very similar.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 86.90476% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (9ac2d41) to head (8a1cbfa).
Report is 34 commits behind head on latest.

Files with missing lines Patch % Lines
src/presolve/HPresolve.cpp 86.90% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2190      +/-   ##
==========================================
+ Coverage   78.92%   78.95%   +0.02%     
==========================================
  Files         345      345              
  Lines       83240    83202      -38     
==========================================
- Hits        65701    65688      -13     
+ Misses      17539    17514      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajhall jajhall merged commit 51a72a9 into ERGO-Code:latest Feb 25, 2025
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants