Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable all non-root presolve #2195

Merged
merged 245 commits into from
Feb 27, 2025

Conversation

fwesselm
Copy link
Collaborator

  • This PR adds a new boolean MIP option mip_root_presolve_only which, if set to true, disables all non-root presolve (i.e. during heuristics, etc.). The default value is false.
  • For example, this option may be helpful in debugging presolve issues.
  • A current limitation is that presolve may still be applied after a MIP restart.
  • A test was added.

svigerske and others added 30 commits December 21, 2024 19:17
- clarify if condition
- declare local function static
Cleared features now in 1.9.0
…r-cran

submit changes necessary for cran
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 84.80769% with 395 lines in your changes missing coverage. Please review.

Please upload report for BASE (no-gesa2@bdf95f2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
extern/filereaderlp/reader.cpp 80.88% 139 Missing ⚠️
src/simplex/SimplexTimer.h 0.00% 83 Missing ⚠️
src/util/FactorTimer.h 0.00% 39 Missing ⚠️
src/presolve/HPresolve.cpp 93.42% 20 Missing ⚠️
src/lp_data/HighsSolution.cpp 24.00% 19 Missing ⚠️
src/mip/HighsMipSolverData.cpp 86.79% 14 Missing ⚠️
src/lp_data/HighsOptions.cpp 70.73% 12 Missing ⚠️
src/simplex/HEkk.cpp 10.00% 9 Missing ⚠️
src/lp_data/Highs.cpp 93.57% 7 Missing ⚠️
src/mip/HighsMipSolver.cpp 90.66% 7 Missing ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff             @@
##             no-gesa2    #2195   +/-   ##
===========================================
  Coverage            ?   78.98%           
===========================================
  Files               ?      345           
  Lines               ?    83252           
  Branches            ?        0           
===========================================
  Hits                ?    65754           
  Misses              ?    17498           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwesselm fwesselm changed the title Add option to enable all non-root presolve Add option to disable all non-root presolve Feb 27, 2025
@jajhall jajhall changed the base branch from latest to no-gesa2 February 27, 2025 13:51
@jajhall jajhall merged commit a7db6c8 into ERGO-Code:no-gesa2 Feb 27, 2025
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants