Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No gesa2 #2196

Merged
merged 15 commits into from
Feb 27, 2025
Merged

No gesa2 #2196

merged 15 commits into from
Feb 27, 2025

Conversation

jajhall
Copy link
Member

@jajhall jajhall commented Feb 27, 2025

The unit test presolve-only-at-root added by @fwesselm used gesa2.mps, and took 3s in debug, increasing the run ime of bin/unit_tests by 15%.

Using rgn.mps exposes about as much use of the mip_root_presolve_only option as gesa2.mps, and the unit test is only 1.5s.

The test itself merely checks that Highs::run() returns HighsStatus::kOk so is of questionable value

@jajhall jajhall self-assigned this Feb 27, 2025
@jajhall jajhall changed the base branch from master to latest February 27, 2025 14:20
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 84.73077% with 397 lines in your changes missing coverage. Please review.

Please upload report for BASE (latest@bdf95f2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
extern/filereaderlp/reader.cpp 80.88% 139 Missing ⚠️
src/simplex/SimplexTimer.h 0.00% 83 Missing ⚠️
src/util/FactorTimer.h 0.00% 39 Missing ⚠️
src/presolve/HPresolve.cpp 92.76% 22 Missing ⚠️
src/lp_data/HighsSolution.cpp 24.00% 19 Missing ⚠️
src/mip/HighsMipSolverData.cpp 86.79% 14 Missing ⚠️
src/lp_data/HighsOptions.cpp 70.73% 12 Missing ⚠️
src/simplex/HEkk.cpp 10.00% 9 Missing ⚠️
src/lp_data/Highs.cpp 93.57% 7 Missing ⚠️
src/mip/HighsMipSolver.cpp 90.66% 7 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff            @@
##             latest    #2196   +/-   ##
=========================================
  Coverage          ?   78.98%           
=========================================
  Files             ?      345           
  Lines             ?    83252           
  Branches          ?        0           
=========================================
  Hits              ?    65755           
  Misses            ?    17497           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajhall jajhall merged commit 000923c into latest Feb 27, 2025
275 checks passed
@jajhall jajhall deleted the no-gesa2 branch February 27, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants