Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPS read mods #2199

Merged
merged 6 commits into from
Mar 1, 2025
Merged

MPS read mods #2199

merged 6 commits into from
Mar 1, 2025

Conversation

jajhall
Copy link
Member

@jajhall jajhall commented Feb 28, 2025

Limited excess printing of warnings in the MPS file by doing so with decreasing frequency, adding reporting of total number of each type of warning issued.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 83.91960% with 32 lines in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (ca0d691) to head (9acbd2a).
Report is 27 commits behind head on latest.

Files with missing lines Patch % Lines
src/io/HMpsFF.cpp 83.22% 27 Missing ⚠️
src/io/HMPSIO.cpp 60.00% 4 Missing ⚠️
src/io/FilereaderMps.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2199      +/-   ##
==========================================
+ Coverage   78.67%   78.76%   +0.09%     
==========================================
  Files         343      343              
  Lines       82864    82988     +124     
==========================================
+ Hits        65190    65363     +173     
+ Misses      17674    17625      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…s, bounds etc by only accepting them as section names if nothing follows on the line
@jajhall
Copy link
Member Author

jajhall commented Feb 28, 2025

Allowed MPS section names to be used as names for columns, RHS, ranges, bounds etc by only accepting them as section names if nothing follows on the line.

Doesn't work for NAME, OBJSENSE, QCMATRIX and QSECTION, since they can be followed by text.

No sane modeller would use "RHS" as a column name, but I've found one that does!

@jajhall jajhall merged commit ef5be32 into latest Mar 1, 2025
275 checks passed
@jajhall jajhall deleted the mps-read-modes branch March 1, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant