Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Eulerian dycore #1215

Open
wants to merge 10 commits into
base: cam_development
Choose a base branch
from
Open

Conversation

brian-eaton
Copy link
Collaborator

@brian-eaton brian-eaton commented Dec 30, 2024

Resolves #1170 - Remove Eulerian dycore from cam_development

Resolves #1148 - Update fire_emissions_factors in hist_trop_strat_vbsfire_cam6 usecase
. Note that this only changes answers for compset FCfireHIST which is not tested in the aux_cam group.

@brian-eaton brian-eaton added the BFB bit for bit tag label Dec 30, 2024
@brian-eaton brian-eaton self-assigned this Dec 30, 2024
@cacraigucar cacraigucar self-requested a review January 2, 2025 21:40
@cacraigucar
Copy link
Collaborator

A quick grep for "eul" in your modified code showed:

  • some remnants of eul in tools/nudging.
  • bld/scripts/remapfv2eul.ncl which say it maps from fv2 to eul. Is this script still relevant?
  • bld/namelist/namelist_defintion.xml has eulc in a number of places. I'm not sure it that is still relevant or not.

There were plenty of other places in the CAM code where "eulerian" is still used, but I think they don't relate to the dycore EUL

@brian-eaton
Copy link
Collaborator Author

I didn't touch the code in tools/nudging because it's not part of the EUL dycore, and more importantly, I don't have a way to test whether or not I broke it. But I'll go ahead and remove the Eulerian option if you think that's best.

I've removed bld/scripts/remapfv2eul.ncl.

The eulc references in namelist_definition.xml are related to vertical advection in SCAM. I think that use is independent of the EUL dycore. @jtruesdal, could you comment?

@cacraigucar
Copy link
Collaborator

@patcal - Can you advise us on whether or not the eul option should be removed from the tools/nudging code, since this PR is removing the Eulerian dycore completely from CAM?

@jtruesdal
Copy link
Collaborator

@brian-eaton I would like to keep the eulc namelist definitions for SCAM as we hope to provide a simple eularian vertical transport for the single column model that is not associated with the current eul dycore.

@brian-eaton
Copy link
Collaborator Author

@cacraigucar, I've removed the references to the EUL dycore from the nudging tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB bit for bit tag CoupledEval3
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants