Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_058: Fix Exner bug in CLUBB interface and change CLUBB namelist #1231

Open
wants to merge 1 commit into
base: cam_development
Choose a base branch
from
Open

cam6_4_058: Fix Exner bug in CLUBB interface and change CLUBB namelist #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bld/namelist_files/namelist_defaults_cam.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2214,7 +2214,7 @@
<clubb_l_intr_sfc_flux_smooth phys="cam7" > .true. </clubb_l_intr_sfc_flux_smooth>
<clubb_l_lmm_stepping > .false. </clubb_l_lmm_stepping>
<clubb_l_lscale_plume_centered > .false. </clubb_l_lscale_plume_centered>
<clubb_l_min_wp2_from_corr_wx > .true. </clubb_l_min_wp2_from_corr_wx>
<clubb_l_min_wp2_from_corr_wx > .false. </clubb_l_min_wp2_from_corr_wx>
<clubb_l_min_xp2_from_corr_wx > .true. </clubb_l_min_xp2_from_corr_wx>
<clubb_l_mono_flux_lim_rtm > .true. </clubb_l_mono_flux_lim_rtm>
<clubb_l_mono_flux_lim_spikefix > .true. </clubb_l_mono_flux_lim_spikefix>
Expand Down
13 changes: 13 additions & 0 deletions doc/ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
One-line Summary: Fix Exner bug in CLUBB interface and change CLUBB namelist

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

The computation of the Exner function in the CLUBB interface code currently passes an incorrect version to the PBL utilities. The PBL utilities expect the "Stull" definition of the Exner function rather than the traditional "atmospheric" Exner function.
(Github issue 1222)

The CLUBB group has recommended a namelist change to address this issue.
(Github issue 1208)


Expect baseline failures for all applications using CLUBB.

===============================================================

Tag name: cam6_4_056
Expand Down
4 changes: 2 additions & 2 deletions src/physics/cam/clubb_intr.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4700,8 +4700,8 @@ subroutine clubb_tend_cam( state, ptend_all, pbuf, hdtime, &
! --------------------------------------------------------------------------------- !
do i=1,ncol
do k=1,pver
!use local exner since state%exner is not a proper exner
th(i,k) = state1%t(i,k)*inv_exner_clubb(i,k)
!subroutine pblind expects "Stull" definition of Exner
th(i,k) = state1%t(i,k)*state1%exner(i,k)
!thv should have condensate loading to be consistent with earlier def's in this module
thv(i,k) = th(i,k)*(1.0_r8+zvir*state1%q(i,k,ixq) - state1%q(i,k,ixcldliq))
enddo
Expand Down
Loading