Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_063: Update namelist settings #1252

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

cacraigucar
Copy link
Collaborator

@cacraigucar cacraigucar commented Feb 7, 2025

Closes #1251
Closes #1249

No need for this test anymore. I checked out a CESM configuration and used this branch in it. I then ran a create_newcase using the same compset/grid that Cecile is using and confirmed that I got all of the requested settings after running preview_namelists. [@cecilehannay - Could you please checkout this branch and make sure that you get the namelist settings you want? I tested it with an FLTHIST and it worked.}

@briandobbins - Does this PR indeed close your issue?
@ekluzek - Including you in case you see any problems

Copy link
Collaborator

@PeterHjortLauritzen PeterHjortLauritzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacraigucar!

This is beyond the scope of the current PR, but I wonder if we should use the same values for MPAS as well for dust_emis_fact since it currently keys off the dycore with dyn="se" (at least as a starting point instead of the default)

In terms of code, add

<dust_emis_fact dyn="mpas" phys="cam7" >2.30D0</dust_emis_fact>

If @adamrher is OK with that I think we should make that change now to avoid possible wasted CPU hours running simulations thinking the paramters are the same as SE with MPAS ...

Copy link

@adamrher adamrher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approved this contingent on my one suggested change.

I'm fine with Peter's suggestion to add a dust_emis_fact entry conditioned on mpas and cam7.

bld/namelist_files/namelist_defaults_cam.xml Outdated Show resolved Hide resolved
Copy link

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ask a couple questions, about dust_emis_fact, but I don't know the answers, so will let others evaluate.

The dust emis method change looks correct to me. So good to go as far as I can tell.

@@ -2529,6 +2529,7 @@
<dust_emis_fact dyn="fv" phys="cam5" clubb_sgs="1" >0.22D0</dust_emis_fact>
<dust_emis_fact dyn="se" phys="cam6" >0.70D0</dust_emis_fact>
<dust_emis_fact dyn="se" phys="cam7" >2.30D0</dust_emis_fact>
<dust_emis_fact dyn="mpas" phys="cam7" >2.30D0</dust_emis_fact>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about dust_emis_fact for cam7 and fv?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterHjortLauritzen @adamrher - I need you to answer this

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are numerous entries for fv and cam7, and so my last comment "all cam7 entries should be 2.3" would resolve this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not supporting FV with CAM7

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @adamrher and my comment crossed "mid air". Sounds good with @adamrher suggestion ...

@@ -2529,6 +2529,7 @@
<dust_emis_fact dyn="fv" phys="cam5" clubb_sgs="1" >0.22D0</dust_emis_fact>
<dust_emis_fact dyn="se" phys="cam6" >0.70D0</dust_emis_fact>
<dust_emis_fact dyn="se" phys="cam7" >2.30D0</dust_emis_fact>
<dust_emis_fact dyn="mpas" phys="cam7" >2.30D0</dust_emis_fact>
<dust_emis_fact dyn="se" hgrid="ne30np4" phys="cam6" chem="trop_strat_mam4_vbs">0.8D0</dust_emis_fact>
<dust_emis_fact dyn="se" hgrid="ne30np4" phys="cam7" chem="trop_strat_mam4_vbs">0.8D0</dust_emis_fact>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right for cam7 with Leung dust?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterHjortLauritzen @adamrher - I need you to answer this one also

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- all cam7 dust_emis_fact's should be 2.3, so we should change this trop_strat_mam4_vbs entry to 2.3.

@@ -2563,7 +2564,8 @@
<dust_emis_fact hgrid="0.47x0.63" offline_dyn="1" phys="cam7" ver="chem">0.9D0</dust_emis_fact>

<!-- dust emissions method -->
<dust_emis_method>Leung_2023</dust_emis_method>
<dust_emis_method> Zender_2003</dust_emis_method>
<dust_emis_method phys="cam7" > Leung_2023</dust_emis_method>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me.

@cacraigucar cacraigucar requested a review from adamrher February 7, 2025 22:59
@cacraigucar
Copy link
Collaborator Author

@adamrher - could you please re-review and approve the latest dust_emis_fact change matches what we talked about offline and that you don't see any problems with these extensive changes

@cacraigucar
Copy link
Collaborator Author

@PeterHjortLauritzen - It looks like I should have you double check this as well - I asked for re-review

Copy link

@adamrher adamrher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@cacraigucar cacraigucar merged commit b90429e into ESCOMP:cam_development Feb 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

4 participants