Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmeps sectorwater for pull request #351

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TaranuDev
Copy link

Description of changes

Here we add support for sectoral water abstraction module in CESM.
While the withdrawal, consumption and return flow fluxes for each of the sectors are computed in the land component (CLM/CTSM), the water is supplied from the routing model (MOSART in our case).

Therefore, there is a need to communicate these fluxes between the two models.

CMEPS Issues Fixed (include github issue #): 350

Are changes expected to change answers?
In the land component, there will be some small changes to the surface water-energy balance due to the fact that we apply the consumed water for sectoral usage on top of the soil columns covered by natural vegetation.

In the routing model, there will be some changes to the total water storage (VOLR) and final discharge into the oceans, since the sectoral water usage have a consumption element (meaning that the withdrawal is larger than the return flow, as some water is lost in the process).

Any User Interface Changes (namelist or namelist defaults changes)?
Not in CMEPS specifically, but yes.
In CTSM, we added some new namelist variables with default values already fixed. More about this in the dedicated pull request for the CTSM codebase.

Testing performed

Extensive testing was performed, with different namelist configurations. Main goal was testing the model performance, then there are no inconsistencies between expected model behavior and results, but also model stability.
The model is behaving according to the design, and is completely stable (we performed simulations up to 30 years with no errors or issues).

For any questions, please contact me at [email protected].
I will be happy to assist to resolve any issues or anything unclear.

@ekluzek ekluzek self-assigned this Apr 6, 2023
@ekluzek ekluzek added enhancement New feature or request CESM only labels Apr 6, 2023
@ekluzek
Copy link
Collaborator

ekluzek commented Apr 6, 2023

Because of the number of fields here, and because this won't be the default way of running, we will need a switch to activate passing these fields through the system. This should be a namelist item added to the drv_flds_in namelist file. That's the first thing I see from a first pass of looking through this.

@wwieder
Copy link

wwieder commented Apr 6, 2023

Let's assess the scientific priority of the CTSM side of this PR before pushing forward on the externals associated with the work.

@jedwards4b
Copy link
Collaborator

Please refer to the related CTSM PR for further discussion and timeline. I am converting this to draft status for now.

@jedwards4b jedwards4b marked this pull request as draft June 22, 2023 16:14
@samsrabin
Copy link

Wanted to note here that I'm the assignee for the parent PR, ESCOMP/CTSM#1975.

@ekluzek ekluzek added the Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CESM only enhancement New feature or request Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants