-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New soiltex for ctsm5.2.mksurfdata #1732
Merged
slevis-lmwg
merged 38 commits into
ESCOMP:ctsm5.2.mksurfdata
from
slevis-lmwg:new_soiltex_slevis
Oct 4, 2022
Merged
Changes from 25 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
a849f95
new soil texture dataset
8de015d
new soil texture file
c79e8fc
Merge branch 'feature/new_mksurfdata' into feature/new_mksurfdata_soi…
3da0c0a
more changes to mksoiltexnewMod.F90
98c78b1
more updates to mksoiltexnewMod.F90
048dc94
fixes to get mapunits mapped and generated correctly
2491f62
more updates to get PCT_SAND and PCT_CLAY output for new soil dataset
f855eff
turned on other fields
c5e496b
revert any changes to original mksoiltexMod.F90
82c3924
Merge branch 'feature/new_mksurfdata' into feature/new_mksurfdata_soi…
191803f
fixed order in calls of mksurfdata
d7e2da6
%sand and %clay are now being computed without any zero values
057714f
mksurfdata now generates the entire surface dataset
474cd95
moved soiltexnewMod.F90 to soiltexMod.F90
3e6d2f2
Merge remote-tracking branch 'escomp/ctsm5.2.mksurfdata' into feature…
slevis-lmwg 0216669
Change jobscript to point to /bld instead of /src
slevis-lmwg cd04245
Merge branch 'cmake_bld_branch' into feature/new_mksurfdata_soiltex
slevis-lmwg 1d7bbc1
Merge remote-tracking branch 'escomp/ctsm5.2.mksurfdata' into new_soi…
slevis-lmwg 9ca5228
Remove hardwiring of new soil texture mapunit and lookup files
slevis-lmwg efd5ca2
Update .xml with renamed mksrf_soitex* files
slevis-lmwg d53d1b9
Update .xml with renamed mksrf_soitex* files after review comments
slevis-lmwg 2e7fc48
Add the --hires_soitex option to gen_mksurfdata_namelist.py
slevis-lmwg 195ae0d
Untested mods to obtain ORGANIC from the new soil dataset
slevis-lmwg c1bde16
Clean-up in code & README; the code runs but ORGANIC is wrong
slevis-lmwg 6c8ef8b
Define .nc variable ORGANIC as float instead of double
slevis-lmwg f7c80ec
Set organic to 0 when mapunit = 0 or lookup returns negative value
slevis-lmwg ba8d426
Added to fsurdat: BULK, CFRAG, PHAQ, ORGC (and ORGANIC temporarily)
slevis-lmwg c55575c
Merge remote-tracking branch 'escomp/ctsm5.2.mksurfdata' into new_soi…
slevis-lmwg 73950a3
Update .xml file with new glacier, new lakedepth files, rm merge_gis opt
slevis-lmwg 9b37f01
Upd .xml file w new hist data (1850-2015) w the new absolute values
slevis-lmwg e0fd2b1
Merge remote-tracking branch 'escomp/ctsm5.2.mksurfdata' into new_soi…
slevis-lmwg 1cc1fad
Add "_cdf5_" to transient urban rawdata file names
slevis-lmwg 59785d4
Read lakedepth & %lake separately to get the latter from transient files
slevis-lmwg 94b844b
Update .xml with "rimport" locations of most new files
slevis-lmwg e4ad556
Of two calculation options for ORGANIC, switch to the preferred option
slevis-lmwg 7c05469
Default do_transient_urban & _lakes to .true. for transient compsets
slevis-lmwg ac53754
Correcting typo from the last commit
slevis-lmwg ea5dbae
Change variable haslake to pct_lake_max throughout
slevis-lmwg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,7 +176,19 @@ def get_parser(): | |
[default: %(default)s] | ||
""", | ||
action="store_true", | ||
dest="hres_flag", | ||
dest="hres_pft", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed hres_flag to hres_pft to distinguish it from the new hres_soitex. |
||
default=False, | ||
) | ||
parser.add_argument( | ||
"--hires_soitex", | ||
help=""" | ||
If you want to use the high-resolution soil texture dataset rather | ||
than the default lower resolution dataset. | ||
(Low resolution is 5x5min, high resolution 30-second) | ||
[default: %(default)s] | ||
""", | ||
action="store_true", | ||
dest="hres_soitex", | ||
default=False, | ||
) | ||
parser.add_argument( | ||
|
@@ -245,7 +257,8 @@ def main (): | |
potveg = args.potveg_flag | ||
glc_nec = args.glc_nec | ||
merge_gis = args.merge_gis | ||
if args.hres_flag: | ||
|
||
if args.hres_pft: | ||
if (start_year == 1850 and end_year == 1850) or \ | ||
(start_year == 2005 and end_year == 2005): | ||
hires_pft = 'on' | ||
|
@@ -254,6 +267,12 @@ def main (): | |
sys.exit(5) | ||
else: | ||
hires_pft = 'off' | ||
|
||
if args.hres_soitex: | ||
hires_soitex = 'on' | ||
else: | ||
hires_soitex = 'off' | ||
|
||
verbose = args.verbose | ||
|
||
if force_model_mesh_file != 'none': | ||
|
@@ -319,6 +338,7 @@ def main (): | |
|
||
# create attribute list for parsing xml file | ||
attribute_list = {'hires_pft':hires_pft, | ||
'hires_soitex':hires_soitex, | ||
'pft_years':pft_years, | ||
'pft_years_ssp':pft_years_ssp, | ||
'ssp_rcp':ssp_rcp, | ||
|
@@ -390,6 +410,10 @@ def main (): | |
new_key = f"{child1.tag}_urban" | ||
rawdata_files[new_key] = os.path.join(input_path, item.text) | ||
|
||
if item.tag == 'lookup_filename': | ||
new_key = f"{child1.tag}_lookup" | ||
rawdata_files[new_key] = os.path.join(input_path, item.text) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needed for the newly introduced soil texture lookup file. |
||
|
||
# determine output mesh | ||
tree2 = ET.parse('../../ccs_config/component_grids_nuopc.xml') | ||
root = tree2.getroot() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this README file, this is the only substantial change (others just improve the formatting):
It documents that I haven't run successfully with the new 30-sec soil-texture data.