Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hist_all_htapes namelist flag to output all history fields #2061

Open
wants to merge 10 commits into
base: b4b-dev
Choose a base branch
from

Conversation

johnpaulalex
Copy link
Contributor

@johnpaulalex johnpaulalex commented Jul 17, 2023

Also made rah1 history field properly initialize itself (it was not overwriting its NaNs to spvals like every other field does)

Specific notes

Contributors other than yourself, if any: @ekluzek, @samsrabin

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Added new hist_all_htapes namelist flag, defaults to false (a no-op).

Testing performed, if any:

  • SMS_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-default--clm-all_outputs gets 1369 variables saved to the h0 file.
  • ERP_Ld9.f45_f45_mg37.I2000Clm50FatesRs.derecho_intel.clm-FatesColdAllVars now has two extra variables.

…n the primary history tape (the opposite of hist_empty_htapes). hist_fexcl* flags can be used on top of it, to disable individual fields.

Add 'all_outputs' test to exercise the flag (and add that test to aux_clm).
@johnpaulalex johnpaulalex requested a review from ekluzek July 17, 2023 00:33
@samsrabin
Copy link
Collaborator

Looks like this does affect FATES variables too; after e53049f, the FatesColdAllVars test has two more variables. That's not as many as I expected based on #2833, but that might be due to FATES mode settings.

@ekluzek ekluzek changed the base branch from master to b4b-dev November 7, 2024 18:41
@ekluzek ekluzek added this to the CESM3 Answer changing freeze milestone Dec 12, 2024
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability bfb bit-for-bit labels Dec 12, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Dec 12, 2024

I ran testing. Izumi was fine.
A few unexpected fails pm Derecho to look into, mostly build errors....

ERP_Ld9.f45_f45_mg37.I2000Clm50FatesRs.derecho_intel.clm-FatesColdAllVars	(NLCOMP COMPARE_base_rest BASELINE)		
ERS_D_Ld5.f10_f10_mg37.IHistClm50BgcQian.derecho_intel.clm-ciso_bombspike1963DecStart--clm-matrixcnOn_ignore_warnings	(MODEL_BUILD)		
ERS_D_Mmpi-serial_Ld5.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesCold	(MEMCOMP SHORT_TERM_ARCHIVER)		
LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.clm-lilac	(NLCOMP MODEL_BUILD)		
NCK_Ld1.f10_f10_mg37.I2000Clm50Sp.derecho_intel.clm-default	(MODEL_BUILD)		
PEM_D_Ld5.ne30_g17.I2000Clm50BgcCru.derecho_intel.clm-default	(MODEL_BUILD)		
PET_P64x2_D.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default	(MODEL_BUILD)		
PET_P64x2_D.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default--clm-matrixcnOn_ignore_warnings	(MODEL_BUILD)		
SMS_D_Ld3.f10_f10_mg37.I2000Clm50BgcCru.derecho_intel.clm-default	(MODEL_BUILD)		
SMS_D_Ld5.f09_g17.ISSP126Clm50BgcCrop.derecho_intel.clm-datm_ssp126_anom_forc	(MODEL_BUILD)		
SMS_Ld2_D_PS.f09_g17.I1850Clm60BgcCropCmip6.derecho_intel.clm-basic_interp	(MODEL_BUILD)		
SMS_Ln9.ne30pg2_ne30pg2_mg17.I2000Clm50BgcCrop.derecho_intel.clm-clm50cam6LndTuningMode	(MODEL_BUILD)		
SSP_D_Ld4.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-ciso_rtmColdSSP	(MODEL_BUILD)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

add namelist option to turn on all history fields, add a CLM test that uses this
3 participants