[Fang summer '24 PR 1.1] Fix bugs and develop crop fire modeling #2684

3 / 3 tasks completed

All tasks have been completed

@lifang0209

Task	Status
Fixed the bug described in #2566 to avoid incorrect accumulation of baf_crop and ensure that crop fires do not occur during the crop growing season;	Incomplete
Confined crop fires to periods after harvest and before planting when crop module is active;	Incomplete
Removed the dependency of baf_crop on fuel availability;	Incomplete
Improved the modeling of the influence of socio-economic factors on crop burned area	Incomplete
Recalibrated the cropfire_a1 constant based on GFED5 crop burned area;	Incomplete
Modify the declaration of CNFireArea in these F90 files to include the variable crop_inst, declare the variable crop_inst, and import and utilize crop_type from the module CropType.	Incomplete
Resolves #2566	Incomplete
Adds optional `fire_method` `li2024gswpfrc`.	Incomplete
@lifang0209 performed historic Bgc and BgcCrop runs to check scientific performance with `li2024gswpfrc`	Incomplete
`aux_clm` test suite passes bit-for-bit, since by default `li2024gswpfrc` is off.	Incomplete
Add comment in all other fire modules that `crop_inst` is just being used as a dummy.	Completed
What do you think of the `fire_method` test coverage I added? Specifically, a 65-day 10x15 derecho intel run with each `fire_method`.	Completed
I had some differences in some tests that were marked as expected failures. There were also two FATES tests that had diffs due to infinity in `FATES_TRANSITION_MATRIX_LULU`. Are those okay?	Completed