-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Clm51 references throughout or change to Clm60 #2808
Remove Clm51 references throughout or change to Clm60 #2808
Conversation
OK aux_clm on derecho before rebasing from master to the cesm3_0_beta04_changes branch. After rebasing to the cesm3_0_beta04_changes branch: This PR is ready to merge. I need to wait for @ekluzek's review and approval, especially due to the potential for conflicts as mentioned in this post. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slevis-lmwg and I went over this and we have a couple changes to make. But, he will make those and then bring this in.
As a final thing to do do a
git grep -i clm5_1
git grep -i Clm51
git grep -i clm5.1
and make sure everthing is handled. We did this before and we thought it was, but good to make sure again.
slevis resolved conflicts: bld/namelist_files/namelist_defaults_ctsm.xml cime_config/testdefs/ExpectedTestFails.xml
Testing before merging Derecho Izumi |
|
ESCOMP@bae4c64 I made the change to get the tests to pass originally. Turns out issue ESCOMP#2784 will resolve the failures, so this time I added the four tests to ExpecedTestFails.xml
Description of changes
TODO list appears in the corresponding issue #2379.
Specific notes
Contributors other than yourself, if any:
@ekluzek
CTSM Issues Fixed (include github issue #):
Most of what's need in #2379
Resolves #2561
CMEPS, CISM and mizuRoute still need to be updated for #2379 to be finalized
Are answers expected to change (and if so in what way)?
No.
Any User Interface Changes (namelist or namelist defaults changes)?
Removing Clm51 references throughout.
Does this create a need to change or add documentation? Did you do so?
Yes.
Testing performed, if any:
On derecho: