Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/replace refs to DATM_C*_YR_* variables #2852

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Oct 30, 2024

Description of changes

As in title.

Specific notes

Contributors other than yourself, if any:
@samsrabin

CTSM Issues Fixed (include github issue #):
Fixes #2743

Are answers expected to change (and if so in what way)?
No

Does this create a need to change or add documentation? Did you do so?
Yes

@slevis-lmwg slevis-lmwg self-assigned this Oct 30, 2024
@slevis-lmwg slevis-lmwg requested a review from samsrabin October 30, 2024 00:53
@slevis-lmwg slevis-lmwg added documentation additions or edits to user-facing documentation bfb bit-for-bit labels Oct 30, 2024
@samsrabin samsrabin marked this pull request as ready for review November 1, 2024 18:48
@samsrabin samsrabin marked this pull request as draft November 1, 2024 18:49
@samsrabin samsrabin marked this pull request as ready for review November 1, 2024 18:49
@slevis-lmwg
Copy link
Contributor Author

Thank you for approving, @samsrabin.

What's your opinion regarding testing here:

  • I'm tempted to merge without testing (though buildnml is not a documentation file).
  • So should I run build-namelist_test.pl when derecho comes back?
  • Or should I just run all testing and not overthink it?

@samsrabin
Copy link
Collaborator

Thank you for approving, @samsrabin.

What's your opinion regarding testing here:

  • I'm tempted to merge without testing (though buildnml is not a documentation file).
  • So should I run build-namelist_test.pl when derecho comes back?
  • Or should I just run all testing and not overthink it?

I think running all NEON tests and then the clm-short suite, plus the build namelist test, should be sufficient.

@samsrabin
Copy link
Collaborator

OH, sorry, I thought this was #2855. I think the build-namelist test only should be fine.

@slevis-lmwg
Copy link
Contributor Author

PASS ./build-namelist_test.pl
FAIL python -s testing BUT error is related to yesterday's derecho updates and occurs in b4b-dev before merging this PR

@slevis-lmwg slevis-lmwg merged commit 33607a0 into ESCOMP:b4b-dev Nov 6, 2024
2 checks passed
@slevis-lmwg slevis-lmwg deleted the rm_refs_to_datm_vars branch November 6, 2024 17:01
@slevis-lmwg
Copy link
Contributor Author

UPDATE
PASS python -s testing after manually running "module load cdo"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit documentation additions or edits to user-facing documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants