Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] run_neon fixes and improvements #2886

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Nov 18, 2024

Work in progress!

Subject to force pushes!

Description of changes

Resolves some bugs and improves some messaging. Also, two new options:

  • --no-inputdata-check option implies --setup-only but skips the check/download of input data.
  • --xmlchange option allows user to specify xmlchange settings to apply. E.g., --xmlchange CLM_CO2_TYPE=constant,CCSM_CO2_PPMV=850.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: Manual testing.

@samsrabin samsrabin added the bug something is working incorrectly label Nov 18, 2024
@samsrabin samsrabin self-assigned this Nov 18, 2024
@wwieder
Copy link
Contributor

wwieder commented Nov 18, 2024

@samsrabin I really appreciate you work here, but also note that all of this is subject to change with #2406 when we integrate the run_towers workflow that @TeaganKing developed and that's waiting for input from @ekluzek . I might hold off making quality of life improvements in run_neon until after we have the plumber2 capability merged.

@samsrabin
Copy link
Collaborator Author

Good point, @wwieder. For now I'll continue to develop this branch just for my own benefit (using it in a demo tomorrow), and after #2406 is merged I can see if anything here would still be useful.

@samsrabin samsrabin added the enhancement new capability or improved behavior of existing capability label Nov 18, 2024
@ekluzek ekluzek added this to the ctsm6.0.0 (code freeze) milestone Dec 5, 2024
@ekluzek ekluzek added the priority: low Background task that doesn't need to be done right away. label Feb 4, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented Feb 4, 2025

@samsrabin just pinging you on this to see if this is something you might be able to do before the release? Also note that #2406 is merged to b4b-dev. So this should probably be merged or re-based to b4b-dev and merged with that, if that's possible for this one.

@samsrabin
Copy link
Collaborator Author

Before the ctsm6.0 release? Yes, I'd still like to get this in before that.

@wwieder
Copy link
Contributor

wwieder commented Feb 4, 2025

Sounds good to me, @samsrabin have a look after we merge b4b-dev? I think then #2406 will be on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly enhancement new capability or improved behavior of existing capability priority: low Background task that doesn't need to be done right away.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_neon --setup-only is ignored run_neon --overwrite is ignored
3 participants