Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctsm5.3.020: Merge b4b-dev 2025-01-16 #2938

Merged
merged 50 commits into from
Jan 17, 2025

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Jan 16, 2025

Description of changes

Regular merge of b4b-dev branch into master. Includes some improvements to test list / expected failures.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: aux_clm passes.

johnpaulalex and others added 30 commits June 14, 2023 10:35
…esn't include the RTM, MOSART or CTSM changes though
iRpointer files for restart now have the simulation timestamp in the filename

Add the simulation timestamp to the rpointer files. Also update submodules with this change
in CMEPS and CDEPS as well as updated cime to handle it. See the notes below for an explaination
about this.

Add a "clm" level directory under usermods_dirs so that the component where user-mods reside
is declared and to make them function the same as test-mods.
…imemgr_init, now timemgr_init is always called, remove things already done in timemgr_init and add documentation around this
…20241230

Merge b4b-dev 20241220

This tag is in the temporary branch tmp-241219, while master remains
"locked" in preparation for a cesm tag.

The process was unorthodox, in that I (slevis) received a code review
and made revisions and retested after having started the first merge
steps.
…nto cesm3_0_beta05_submodules

 Conflicts:
	.gitmodules
… initialize2, change order of alarms to stop first then restart
Bug fix for izumi nag tests to pass (PR into b4b-dev)
Merge tmp-241219 branch to master

Includes three tmp-241219 tags:

tmp-241219.n01.ctsm5.3.016 Merge b4b-dev:
nfix_method options Houlton (default), Bytnerowicz (option)
tmp-241219.n02.ctsm5.3.016 FATES hydro test update
tmp-241219.n03.ctsm5.3.016 Bug fix for izumi nag tests to pass (b4b unless using Bytnerowicz)

Fixes ESCOMP#2924 Fix problem with izumi nag tests
Fixes ESCOMP#2878 Remove fates_allom_smode shell_command update in FatesColdHydro testmod
Fixes ESCOMP#2869 Update temperature cost function for symbiotic nfix in FUN

Changes answers as documented in the ChangeLog.
ekluzek and others added 9 commits January 15, 2025 15:44
Delete unused hist_add_subscript method (no references in the CTSM repo)
doc that masterlist actflag is just h0 in practice, doc that masterlist has all the fields.
Useful for redoing tests that failed due to ESCOMP#2916, after having replaced libraries/mpi-serial with a fresh copy.
Includes merge conflicts in src/cpl/lilac/lnd_comp_esmf.F90 due to PR ESCOMP#2912.
@samsrabin samsrabin added blocker another issue/PR depends on this one bfb bit-for-bit test: aux_clm Pass aux_clm suite before merging labels Jan 16, 2025
@samsrabin samsrabin self-assigned this Jan 16, 2025
slevis-lmwg
slevis-lmwg previously approved these changes Jan 16, 2025
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I include my conflict resolution suggestions.

Approving the PR preemptively. Thanks @samsrabin.

src/cpl/lilac/lnd_comp_esmf.F90 Outdated Show resolved Hide resolved
src/cpl/lilac/lnd_comp_esmf.F90 Outdated Show resolved Hide resolved
@samsrabin samsrabin dismissed slevis-lmwg’s stale review January 16, 2025 20:53

This is still a work in progress.

@samsrabin samsrabin changed the base branch from b4b-dev to master January 16, 2025 21:15
@samsrabin samsrabin marked this pull request as ready for review January 16, 2025 21:28
@samsrabin samsrabin requested a review from ekluzek January 16, 2025 21:28
@samsrabin samsrabin changed the title Merge b4b-dev 2025-01-16 ctsm5.3.020: Merge b4b-dev 2025-01-16 Jan 16, 2025
@samsrabin samsrabin requested a review from slevis-lmwg January 17, 2025 19:26
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsrabin thank you! I'm not familiar with every detail here, but things look good from a quick look.

@samsrabin samsrabin merged commit a4aa4ec into ESCOMP:master Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit blocker another issue/PR depends on this one test: aux_clm Pass aux_clm suite before merging
Projects
Status: Done (non release/external)
Development

Successfully merging this pull request may close these issues.

LILAC fails at build phase because of some changes needed for the rpointer handling
4 participants