Small fixes + edits to gendisk example yaml file #29
Conversation
| LMAX : 6 # Number of harmonics for Spherical SL for halo/spheroid | ||
| LMAXFID : 64 # Number of harmonics for Spherical SL for determining disk basis | ||
| LMAX : 18 # Number of harmonics for Spherical SL for halo/spheroid | ||
| LMAXFID : 128 # Number of harmonics for Spherical SL for determining disk basis (may want to bump to 256) |
There was a problem hiding this comment.
I'm surprised this LMAXFID hasn't created complaints before -- LMAXFID will scale runtime like LMAXFID squared. Earlier tests have shown that for realistic disc scale height-to-length ratios (e.g. 15%), this will be overkill unless all other parameters are equally boosted. I'd recommend LMAXFID : 72 or thereabouts.
| LOGR : true # Make a logarithmic coordinate mapping | ||
| MMAX : 6 # Number of azimuthal harmonics for disk basis | ||
| NCHEB : 16 # Chebyshev order for smoothing | ||
| NDP : 1 | ||
| CHEBY : false # Chebyshev smoothing |
There was a problem hiding this comment.
It probably makes sense to move these to expert parameters, as Chebyshev smoothing is generally dangerous unless using all the diagnostic files.
| NDP : 1 | ||
| CHEBY : false # Chebyshev smoothing | ||
| NCHEB : 12 # Chebyshev order for smoothing if CHEBY = true | ||
| NDP : 8 # Number of angular wedges for disc |
There was a problem hiding this comment.
1 is fine here because we are assuming axisymmetry when generating the disc.
(also we have to decide disc vs disk)
| NMAXH : 18 # Number of radial basis functions in Spherical SL for halo/spheroid | ||
| NMAXFID : 72 # Number of radial basis functions in Spherical SL for determining disk basis | ||
| NODD : 8 # Number of vertically antisymmetric disk basis functions per M-order | ||
| NMAXFID : 64 # Number of radial basis functions in Spherical SL for determining disk basis (may want to bump to 128) |
There was a problem hiding this comment.
Tests largely again showed that larger than 72 was overkill; but this also isn't as expensive, so it's fine.
| NUMDF : 1000 # Number of grid points for Eddington inversion | ||
| NUMR : 1000 # Size of radial grid for Spherical SL | ||
| NUMR : 2000 # Size of radial grid for Spherical SL |
There was a problem hiding this comment.
| NUMR : 2000 # Size of radial grid for Spherical SL | |
| NUMR : 2000 # Size of radial grid for Spherical SL (ideally this matches the input halo file) |
| NUMX : 256 # Radial grid size for disk basis table | ||
| NUMY : 128 # Vertical grid size for disk basis table | ||
| PNUM : 1 # Number of azimthal knots for EmpCylSL basis construction quadrature | ||
| RCYLMAX : 20.0 # Maximum disk radius | ||
| RCYLMAX : 20.0 # Maximum disk radius in units of ASCALE |
There was a problem hiding this comment.
| RCYLMAX : 20.0 # Maximum disk radius in units of ASCALE | |
| RCYLMAX : 20.0 # Maximum disk table radius in units of ASCALE |
| RFACTOR : 1 # Disk radial scaling factor for spherical deprojection model | ||
| RMIN : 0.00001 # Minimum halo radius | ||
| RFACTOR : 1.0 # Disk radial scaling factor for spherical deprojection model | ||
| RMIN : 0.001 # Minimum halo radius |
There was a problem hiding this comment.
| RMIN : 0.001 # Minimum halo radius | |
| RMIN : 0.001 # Minimum halo radius (ideally this matches the input table, or is larger) |
| RNUM : 200 # Number of radial knots for EmpCylSL basis construction quadrature | ||
| RSPHSL : 4.00 # Maximum halo expansion radius | ||
| RSPHSL : 1.95 # Maximum halo expansion radius |
There was a problem hiding this comment.
| RSPHSL : 1.95 # Maximum halo expansion radius | |
| RSPHSL : 1.95 # Maximum halo expansion radius (ideally this matches the input table, or is smaller) |
| cachefile : XXXXX # Name of EOF cache file (e.g. eof.cache.fileF) | ||
| centerfile : # Read position and velocity center from this file | ||
| constheight : true # Use constant disk scale height | ||
| dbods : disk.bods # Disk particle output file | ||
| deproject : Exponential # set deprojection model (Exponential or MN) | ||
| deproject : EXP # set deprojection model (Exponential or MN) |
There was a problem hiding this comment.
Technically, the code only checks for MN input right now, and then defaults to exponential. So we should set this with whatever is clearest and update documentation elsewhere.
I made a few small fixes to typos and other minor issues in some of the pages. I also changed the parameters in the gendisk example yaml file to reflect the default values. I deleted the gas-related parameters and at least one defunct option