-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Ability to Integrate with TSM #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demonstrate linkage in jupyter notebook #43
aufdenkampe
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjordan29, this PR looks great. It demonstrates the capability to couple with TSM and profiles the performance of that coupling test case, setting us up nicely for the next round of work on:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose merging this initial approach for integrating TSM and Clearwater-Riverine. This PR includes the following:
initialize()
method consistent with BMI. Ultimately, this can get linked with theClearwaterRiverine
init
, but for now I am keeping them separate to allow for easier testing since initialization can be slow with many timesteps. We can revisit this when Speed up calculation of theSUM_OF_COEFFICIENTS_TO_DIFFUSION_TERM
#49 is closed.update()
method consistent with BMI. The previous code only allowed users to run the entire model at once. This new method allows users to increment by a single timestep.plot()
method and its dependencies to work with the new incremental timestep approach.simulate_wq()
so that old demos do not break.These additions allow clearwater riverine to run in a loop with clearwater modules for TSM, as demonstrated in
examples/dev_sandbox/43_Realistic_TSM_Scenario.ipynb
. I propose that this close #43 and that we open more specific issues as needed as we polish that demo.