Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Ability to Integrate with TSM #53

Merged
merged 13 commits into from
Nov 30, 2023
Merged

Basic Ability to Integrate with TSM #53

merged 13 commits into from
Nov 30, 2023

Conversation

sjordan29
Copy link
Contributor

I propose merging this initial approach for integrating TSM and Clearwater-Riverine. This PR includes the following:

  • Addition of an initialize() method consistent with BMI. Ultimately, this can get linked with the ClearwaterRiverine init, but for now I am keeping them separate to allow for easier testing since initialization can be slow with many timesteps. We can revisit this when Speed up calculation of the SUM_OF_COEFFICIENTS_TO_DIFFUSION_TERM #49 is closed.
  • Addition of an update() method consistent with BMI. The previous code only allowed users to run the entire model at once. This new method allows users to increment by a single timestep.
  • Modifications to the plot() method and its dependencies to work with the new incremental timestep approach.
  • Preserves simulate_wq() so that old demos do not break.

These additions allow clearwater riverine to run in a loop with clearwater modules for TSM, as demonstrated in examples/dev_sandbox/43_Realistic_TSM_Scenario.ipynb. I propose that this close #43 and that we open more specific issues as needed as we polish that demo.

Copy link
Member

@aufdenkampe aufdenkampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjordan29, this PR looks great. It demonstrates the capability to couple with TSM and profiles the performance of that coupling test case, setting us up nicely for the next round of work on:

@aufdenkampe aufdenkampe merged commit 52ae1eb into main Nov 30, 2023
@sjordan29 sjordan29 deleted the 43-integrate-tsm branch December 4, 2023 22:22
@aufdenkampe aufdenkampe added this to the TSM coupling demo milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate TSM for January '24 Demo
2 participants