added fallback/workaround for unexplained crashes in Firebase console #714
Conversation
…, unable to reproduce (NullPointerException) added flag to enable/disable and test this workaround via options (CordovaArgs), disabled by default
|
Hi @alexp25 & @EddyVerbruggen any update on this? |
|
@bhaskar-se did you pass safeMode: true option on login(options)? That should prevent unexplained crashes (and the app should just do nothing instead). Also, this workaround was not yet merged, so you may use my fork instead, and see if it fixes the problem. |
| // savedCallbackContext was null in multiple crash reports, unable to reproduce, using this as fallback | ||
| // handle in cordova app e.g. timeouts | ||
| if (savedCallbackContext == null) { | ||
| return; |
There was a problem hiding this comment.
@alexp25 understood the concept here, but one thing if you pay attention is that you are returning from this block if savedCallbackContext is null, and there is no callback for error and no other options to let the caller function know that there is an issue.
Am asking this because savedCallbackContext itself is the callback and the method error is getting called in case of any error.
I doubt this can possibly create another issue which may lead to another potential crash?!
|
hi @EddyVerbruggen |
Fallback/workaround for crashes encountered in Firebase Crashlytics from real users, unable to reproduce on device. Use safeMode option to enable when calling login(options). Now the app won't crash anymore (with this flag enabled) and will just do nothing if the error is encountered (should handle this case with e.g. timeout after app resumes from background in Cordova app). Addressing issues 634, 358, 440, 531 and possibly many more.