fix(radio): disable source 'Invert' option for 'Play Value' SF/GF

[philmoz]

Fixes #5955

[elecpower]

Matching Companion changes required?

[philmoz]

Matching Companion changes required?

Possibly, I haven't checked (on the road so limited access / time).

[3djc]

Not sure this is the best course of action. I cannot see any logical reason why you should not be able to invert here when you can anywhere else. I saw Malte comment on it, but as a user, I makes little sense to prevent it just here.

[gagarinlg]

Not so easy to fix this any other way. I think we should use that fix and look for a different solution for 3.0, in the case there is a need to do so.

[pfeerick]

Something is clearly needed, but I think it might actually be that the playValue function itself needs fixing?

It seems that #5968 fixes this, using Thr and Inv Thr as my test case so far.

[gagarinlg]

playValue uses the source index, in some places, directly as an array index. When the index is negative, it creates "issues" 😉

[3djc]

playValue uses the source index, in some places, directly as an array index. When the index is negative, it creates "issues" 😉

Yes, so does the mixer, but going into it, the mixer uses abs(source) and carries the invert aspect in a separate variable, something like that should be done there i guess

[pfeerick]

Like in #5968? 🤭

[pfeerick]

Closing in favor of #5968