Fixing: Work title "not found", "fail" etc.

[riedde]

Description, Context and related Issue

I introduced a function for joining strings and normalizing space because this combination is used several times and not consistent.

Refs #103 #337 #118

How Has This Been Tested?

Test have been done with the dataset of Baumann-Digital (Cantata, see https://doi.org/10.5281/zenodo.10072485) and WeGA-Klarinettenquintett. As no fail could be reproduced, the code snippets from the refered issues have been implemented and the upcoming errors have been fixed.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document.

[peterstadler]

I have not tested in detail yet but only looked through the code. Except from one typo I would only complain about all the extra node selectors and would recommend to introduce yet another convenience function, i.e. a 1-arity version of eutil:joindAndNormalize following the model of string-join: https://www.w3.org/TR/xpath-functions-31/#func-string-join

[bwbohl]

I have not tested in detail yet but only looked through the code. Except from one typo I would only complain about all the extra node selectors and would recommend to introduce yet another convenience function, i.e. a 1-arity version of eutil:joindAndNormalize following the model of string-join: https://www.w3.org/TR/xpath-functions-31/#func-string-join

Indeed,when at it a 1-arity version would be a good idea!

[riedde]

I have not tested in detail yet but only looked through the code. Except from one typo I would only complain about all the extra node selectors and would recommend to introduce yet another convenience function, i.e. a 1-arity version of eutil:joindAndNormalize following the model of string-join: https://www.w3.org/TR/xpath-functions-31/#func-string-join

I did some approvements. Not tested yet, because of bad internet connection. I'll tell when this is done!

[riedde]

Works on my machine ;-)

[peterstadler]

Thanks for adding the 1-arity version of eutil:joinedAndNormalize#2!

It might be nitpicking but I would prefer to have an imperative function name, i.e. eutil:joinAndNormalize. While there does not seem to be guidelines concerning camelCase or hyphens (see function names eutil:sort-as-numeric-alpha and eutil:getLanguage), it seems to be consensus that the names are imperative rather than in the past tense.

[riedde]

@peterstadler I understand your intention and have switched the functions name.

[peterstadler]

Thanks for all the fixes! I have tested briefly on my machine with the WeGA Klarinettenquintett and it did not fail ;)

[peterstadler]

My suggestion for merging here would be to squash and merge since that'd get rid of several unnecessary commits (including the merge from dev). But if the policy is to keep everything I'm fine with that too …

[peterstadler]

I see that "squash and merge" is not enabled for this repo. That's probably on purpose?

[bwbohl]

with this merged, can we consider the referenced issues (#103, #118, #337) closed?

[riedde]

I'll check that and if the issues are outdated I'll close them.