ensure to return a string #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when $eventualTitles is the empty sequence.
|
Thanks @peterstadler Is this what it should look like? Then I can approve. Before the fix:
After the fix:
|
|
@daniel-jettka yes, that is the "expected" behavior: getLinkTarget.xql does not fail and returns a valid response. The error in the data (the missing file) gets obvious. |
daniel-jettka
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure to return a string when $eventualTitles is the empty sequence.
The error surfaced in the current Open-Faust data where there is a link from the navigator to a non-existent file.
How Has This Been Tested?
Open-Faust data
Types of changes
Overview