fix from amélie review

Elao · May 3, 2021 · d60ecd9 · d60ecd9
1 parent 3b60a21
commit d60ecd9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 16 deletions.
diff --git a/templates/case_study/show.html.twig b/templates/case_study/show.html.twig
@@ -103,19 +103,17 @@
                         {% for technologySlug in caseStudy.technologies %}
                             {% set technology = content_get('App\\Model\\Technology', technologySlug) %}
                             <li>
-                                <a
-                                    {% if technology.show %}
-                                        href="{{ path('technology', { technology: technology.slug }) }}"
-                                    {% endif %}
-                                    class="technologies__item"
-                                >
+                            {% if technology.show %}
+                                <a href="{{ path('technology', { technology: technology.slug })}}" class="technologies__item">
+                                    <img src="{{ asset(technology.logo) }}" alt="Logo {{ technology.logo }}">
+                                    {{ technology.name }}
+                                </a>
+                            {% else %}
                                 <div class="technologies__item">
-                                    {% if technology.logo|default(false) %}
-                                        <img src="{{ asset(technology.logo) }}" alt="logo {{ technology.name }}">
-                                    {% endif %}
+                                    <img src="{{ asset(technology.logo) }}" alt="Logo {{ technology.logo }}">
                                     {{ technology.name }}
                                 </div>
-                                </a>
+                            {% endif %}
                             </li>
                         {% endfor %}
                     </ul>

diff --git a/templates/site/home.html.twig b/templates/site/home.html.twig
@@ -142,16 +142,17 @@
                     {% for item in technos %}
                         {% set techno = content_get('App\\Model\\Technology', item.id) %}
                         <li>
-                            <a
-                                {% if techno.show %}
-                                href="{{ path('technology', { technology: techno.slug })}}"
-                                {% endif %}
-                                class="technologies__item">
+                        {% if techno.show %}
+                            <a href="{{ path('technology', { technology: techno.slug })}}" class="technologies__item">
+                                <img src="{{ asset(techno.logo) }}" alt="{{ item.alt }}">
+                                {{ techno.name }}
+                            </a>
+                        {% else %}
                             <div class="technologies__item">
                                 <img src="{{ asset(techno.logo) }}" alt="{{ item.alt }}">
                                 {{ techno.name }}
                             </div>
-                            </a>
+                        {% endif %}
                         </li>
                     {% endfor %}
                 </ul>