Require rte-ckeditor-image in dev for it to be available in the funct…

…ional test. Issue #4

.github/workflows/ci.yml

@@ -23,17 +23,13 @@ jobs:
       matrix:
         php: [ '8.2', '8.3', '8.4' ]
         minMax: [ 'composerInstall']
-        extra: [ 'composer -- require netresearch/rte-ckeditor-image']
     steps:
       - name: "Checkout"
         uses: actions/checkout@v4
 
       - name: "Composer"
         run: Build/Scripts/runTests.sh -p ${{ matrix.php }} -s ${{ matrix.minMax }}
 
-      - name: "Composer Extra"
-        run: Build/Scripts/runTests.sh -p ${{ matrix.php }} -s ${{ matrix.extra }}
-
       - name: "Functional tests with mariadb"
         if: always()
         run: Build/Scripts/runTests.sh -p ${{ matrix.php }} -d mariadb -s functional

README.md

@@ -74,7 +74,3 @@ Otherwise only description is checked.
 composer install
 ./Build/Scripts/runTests.sh -s functional -d mariadb -p 8.3
 ```
-> **Note**
-> To test the update of the rte-ckeditor-image soft references,
-> you need to install the extension before running the test:
-> `composer req netresearch/rte-ckeditor-image`. Remove it afterwards again.

Tests/Functional/Command/DataSet/sys_file_duplicates_with_references.csv

@@ -5,6 +5,8 @@
 "sys_refindex",,,,,,,
 ,"hash","tablename","recuid","field","softref_key","ref_table","ref_uid"
 ,"507cf53279411321324cd2f424e0681e","tt_content","1","bodytext","typolink_tag","sys_file","1"
+,"507cf53279411321324cd2f424e0681b","tt_content","2","bodytext","typolink_tag","sys_file","1"
 "tt_content",
 ,"uid","bodytext"
 ,1,'<a href="t3://file?uid=1">link</a>'
+,2,'<img data-htmlarea-file-uid="1">'

Tests/Functional/Command/DataSet/sys_file_duplicates_with_references_RESULT.csv

@@ -4,6 +4,8 @@
 "sys_refindex",,,,,,,
 ,"hash","tablename","recuid","field","softref_key","ref_table","ref_uid"
 ,"507cf53279411321324cd2f424e0681e","tt_content","1","bodytext","typolink_tag","sys_file","2"
+,"507cf53279411321324cd2f424e0681b","tt_content","2","bodytext","typolink_tag","sys_file","2"
 "tt_content",
 ,"uid","bodytext"
 ,1,'<a href="t3://file?uid=2">link</a>'
+,2,'<img data-htmlarea-file-uid="2">'

Tests/Functional/Command/UnduplicateCommandTest.php

@@ -6,7 +6,6 @@
 
 use PHPUnit\Framework\Attributes\Test;
 use RuntimeException;
-use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;
 
 class UnduplicateCommandTest extends FunctionalTestCase
@@ -53,20 +52,12 @@ class UnduplicateCommandTest extends FunctionalTestCase
 
     #[Test] public function unduplicateCommandFixesDuplicatesWithReferences(): void
     {
-        if (ExtensionManagementUtility::isLoaded('rte_ckeditor_image')) {
-            $this->importCSVDataSet(__DIR__ . '/DataSet/sys_file_duplicates_with_ref_and_rte-ckeditor-image.csv');
-        } else {
-            $this->importCSVDataSet(__DIR__ . '/DataSet/sys_file_duplicates_with_references.csv');
-        }
+        $this->importCSVDataSet(__DIR__ . '/DataSet/sys_file_duplicates_with_references.csv');
 
         $result = $this->executeConsoleCommand(self::BASE_COMMAND);
 
         // the references are updated, so that the newer sys_file entry (uid=2) is used
-        if (ExtensionManagementUtility::isLoaded('rte_ckeditor_image')) {
-            $this->importCSVDataSet(__DIR__ . '/DataSet/sys_file_duplicates_with_ref_and_rte-ckeditor-image_RESULT.csv');
-        } else {
-            $this->assertCSVDataSet(__DIR__ . '/DataSet/sys_file_duplicates_with_references_RESULT.csv');
-        }
+        $this->assertCSVDataSet(__DIR__ . '/DataSet/sys_file_duplicates_with_references_RESULT.csv');
         self::assertEquals(0, $result['status']);
     }
 

composer.json

@@ -34,6 +34,7 @@
         }
     },
     "require-dev": {
+        "netresearch/rte-ckeditor-image": "^12.0",
         "phpunit/phpunit": "^11",
         "typo3/testing-framework": "8.2.0"
     }