Misc cleanups, add rawtr()/tr(k) descriptor support #474
+347
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgriffiths
force-pushed
the
taproot_btc
branch
from
bd22e66 to
c626439
Compare
jgriffiths
changed the title
jgriffiths
force-pushed
the
taproot_btc
branch
from
c626439 to
58d624d
Compare
We must differentiate between x-only being allowed, mandatory, and not allowed, so the logic is a little more complex. If we get a compressed (non-x-only) hex key for a rawtr() expression, convert it in-place to an x-only key to make future handling simpler.
This is to support rawtr() which can be given either an x-only or compressed (non-x-only) key.
Also extend the pk() test cases to cover the new x-only behaviour for non-taproot descriptors.
raw() with no arguments generates a zero length script. Ensure we tell the caller they need at least one byte of generation space for this case, otherwise they would be passing an invalid (empty) output buffer.
Use a freshly allocated buffer of the computed size to allocate into, so valgrind can warn us of any errant writes. Also add a testcase for a simple key push without CHECKSIG.
jgriffiths
force-pushed
the
taproot_btc
branch
from
58d624d to
6da0029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
rawtr()andtr(k)initially, as the simplest of the taproot descriptor cases.tr(k,script)will be added in a future MR.