doc: fix schema for listconfigs.

We never call `listconfigs` in our tests with `experimental-offers` enabled, so we didn't notice that the schema is wrong: it does not expect the "plugin" field in 'fetchinvoice-noconnect'. The next patch folds the fetchinvoice plugin into the offers plugin, which is enabled even if `experimental-offers` isn't (for `decode`), so we notice it. Signed-off-by: Rusty Russell <[email protected]>
ElementsProject · Jul 9, 2024 · 7f71e63 · 7f71e63
1 parent 991f6dc
commit 7f71e63
Show file tree

Hide file tree

Showing 8 changed files with 166 additions and 142 deletions.
diff --git a/.msggen.json b/.msggen.json
@@ -1794,6 +1794,7 @@
             "ListConfigs.configs.fee-per-satoshi.value_int": 1
         },
         "ListconfigsConfigsFetchinvoice-noconnect": {
+            "ListConfigs.configs.fetchinvoice-noconnect.plugin": 3,
             "ListConfigs.configs.fetchinvoice-noconnect.set": 1,
             "ListConfigs.configs.fetchinvoice-noconnect.source": 2
         },
@@ -7047,6 +7048,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "ListConfigs.configs.fetchinvoice-noconnect.plugin": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "ListConfigs.configs.fetchinvoice-noconnect.set": {
             "added": "pre-v0.10.1",
             "deprecated": false

diff --git a/cln-grpc/proto/node.proto b/cln-grpc/proto/node.proto
diff --git a/cln-grpc/src/convert.rs b/cln-grpc/src/convert.rs
diff --git a/cln-rpc/src/model.rs b/cln-rpc/src/model.rs
diff --git a/contrib/msggen/msggen/schema.json b/contrib/msggen/msggen/schema.json
@@ -15426,6 +15426,13 @@
                     "description": [
                       "Source of configuration setting."
                     ]
+                  },
+                  "plugin": {
+                    "added": "v23.08",
+                    "type": "string",
+                    "description": [
+                      "Plugin which registered this configuration setting."
+                    ]
                   }
                 }
               },

diff --git a/contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py b/contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py
diff --git a/contrib/pyln-testing/pyln/testing/grpc2py.py b/contrib/pyln-testing/pyln/testing/grpc2py.py
@@ -2257,6 +2257,7 @@ def listconfigs_configs_fee_per_satoshi2py(m):
 
 def listconfigs_configs_fetchinvoice_noconnect2py(m):
     return remove_default({
+        "plugin": m.plugin,  # PrimitiveField in generate_composite
         "set": m.set,  # PrimitiveField in generate_composite
         "source": m.source,  # PrimitiveField in generate_composite
     })

diff --git a/doc/schemas/lightning-listconfigs.json b/doc/schemas/lightning-listconfigs.json
@@ -1522,6 +1522,13 @@
                 "description": [
                   "Source of configuration setting."
                 ]
+              },
+              "plugin": {
+                "added": "v23.08",
+                "type": "string",
+                "description": [
+                  "Plugin which registered this configuration setting."
+                ]
               }
             }
           },