hsmd: increase the min version #7088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/hsmd-minversion
branch
2 times, most recently
from
d4ba80b to
209f2d1
Compare
|
Should we remove https://github.com/lightning-signer/c-lightning/blob/a81c1c51f6a1b8dd78c4dcf40c4ab7e7b52a1653/hsmd/hsmd_wire.csv#L22-L26 |
ksedgwic
suggested changes
Feb 19, 2024
vincenzopalazzo
force-pushed
the
macros/hsmd-minversion
branch
2 times, most recently
from
c0de878 to
a76cf2b
Compare
Done in b950c1b |
vincenzopalazzo
force-pushed
the
macros/hsmd-minversion
branch
from
b950c1b to
64ef75c
Compare
vincenzopalazzo
force-pushed
the
macros/hsmd-minversion
branch
2 times, most recently
from
0f2bd91 to
91b6443
Compare
|
Looks like this has to make it into v24.02 to ensure VLS can recognize CLN correctly, and enable the right validations. @vincenzopalazzo can you un-draft this so we can line it up for the release? |
Increasing the min version of the hsmd due that we added new code that required the hsmd to sign an announcements. One of the solution is to increase the min version in this way a signer like VLS fails directly during the init phase. Link: ElementsProject#7074 Changelog-None: hsmd: increase the min version Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/hsmd-minversion
branch
from
3bad94e to
e5673a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the minimum version of the hsmd due to that we added new code that required the hsmd to sign an announcement.
One of the solutions is to increase the minimum version in this way a signer like VLS fails directly during the init phase.
Fixes: #7074