docs: standardise notifications schema #7396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ErikDeSmedt You are not showing up in my reviewers list. Please review the PR. |
ShahanaFarooqui
force-pushed
the
docs-notifications-schema
branch
from
6cdf673 to
b55434b
Compare
ErikDeSmedt
approved these changes
Jun 17, 2024
|
@ErikDeSmedt Can you please ACK and approve the PR if everything is okay? |
|
ACK b55434b |
ShahanaFarooqui
force-pushed
the
docs-notifications-schema
branch
from
b55434b to
a9b6bf7
Compare
|
Ack b55434b |
Changelog-None.
rustyrussell
force-pushed
the
docs-notifications-schema
branch
from
a9b6bf7 to
b0c5fab
Compare
|
Trivial rebase for genfile conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications schema was introduced in the last release (commit 932396e) by @ErikDeSmedt. The last release also had a huge documentation update with PR #6995.
This PR is modifying the notifications schema definitions and json schema according to our latest documentation standard.
Changelog-None.