Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msggen: add missing methods for 24.11 #7549

Merged
merged 2 commits into from
Nov 28, 2024
Merged

msggen: add missing methods for 24.11 #7549

merged 2 commits into from
Nov 28, 2024

Conversation

daywalker90
Copy link
Contributor

@daywalker90 daywalker90 commented Aug 10, 2024 •
edited
Loading

We don't want to fall out of sync again, right?! @rustyrussell @ShahanaFarooqui

EDIT: reworked the PR to include all the missing rpc commands for 24.11:

  • GetEmergencyRecoverData
  • EnableOffer
  • AskRene-Unreserve
  • AskRene-ListLayers
  • AskRene-Create-Layer
  • AskRene-Remove-Layer
  • AskRene-Reserve
  • AskRene-Age
  • GetRoutes
  • AskRene-Disable-Node
  • AskRene-Inform-Channel
  • AskRene-Create-Channel
  • AskRene-Update-Channel
  • AskRene-Bias-Channel
  • AskRene-ListReservations
  • InjectPaymentOnion

Aswell as:

  • Xpay
  • ListAddresses
  • Bkpr-EditDescriptionByPaymentId
  • Bkpr-EditDescriptionByOutpoint
  • Dev-Splice
  • ExposeSecret

@daywalker90 daywalker90 requested a review from cdecker as a code owner August 10, 2024 12:02
This was referenced Aug 11, 2024
Closed
Closed
@rustyrussell
Copy link
Contributor

I'm going to defer these because they're still experimental and I want to reserve the right to change them radically! Maybe by the time we're into next release @Lagrang3 and I will have more confidence?

@rustyrussell rustyrussell added this to the v24.11 milestone Aug 13, 2024
@daywalker90 daywalker90 changed the title msggen: add askrene and getroutes methods msggen: add missing methods for 24.11 Nov 9, 2024
@rustyrussell
Copy link
Contributor

Ack 4968fdb

Several other PRS will conflict (damn generated files) so I'll wait a bit before rebasing and merging this

@daywalker90
Copy link
Contributor Author

Want me to do a separate PR for the rest or add them here?

@rustyrussell
Copy link
Contributor

Want me to do a separate PR for the rest or add them here?

All the other API changes are merged now, so go wild!

@daywalker90
Copy link
Contributor Author

Rebased and added missing methods listed in OP, these are now all missing methods that were added since 24.08

@rustyrussell rustyrussell merged commit 2ba05ef into ElementsProject:master Nov 28, 2024
36 of 39 checks passed
@rustyrussell
Copy link
Contributor

I had to revert this for rc2, as the rust build broke. Will try again after rc2...

@daywalker90
Copy link
Contributor Author

I've looked through the CI jobs. It worked a couple of times and then failed in your rc2 PR run. Looking at the logs it looks to me like it still didn't wait "long" enough for the generated files to be there completely.

@daywalker90
Copy link
Contributor Author

It's not enough that the files exist apparently. The generation could still be ongoing and the compiler would use a half finished file and then complain about missing things that are not missing in fully generated files.

@rustyrussell
Copy link
Contributor

Hmm... weird! I'll look deeper...

But there were crashes in rc1 so I want to release rc2 now :(

@rustyrussell
Copy link
Contributor

I suspect that MSGGEN_GEN_ALL -> MSGGEN_GENALL change, TBH. We can depend on both. I'll try.

@rustyrussell rustyrussell mentioned this pull request Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdecker cdecker cdecker approved these changes

Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
v24.11
Development

Successfully merging this pull request may close these issues.
3 participants
@daywalker90 @rustyrussell @cdecker