renepay: bugfix assertion htlc_total<=known_max #7574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
force-pushed
the
renepay-bugfix-htlctotal
branch
from
d07117d to
5d13c82
Compare
Lagrang3
force-pushed
the
renepay-bugfix-htlctotal
branch
from
7aa263b to
77684a1
Compare
|
Tests have just discovered a bug: |
Lagrang3
force-pushed
the
renepay-bugfix-htlctotal
branch
2 times, most recently
from
b87b113 to
9c968d8
Compare
|
Fixed some failed checks. It is confusing, even for me, the fact that we have sometimes flows with fees and some other times flows without fees (because MCF have flow conservation, fees cannot be transported). After the release I think a good approach Rebased on top of v24.08rc2 to fix conflicts. |
Draft
Lagrang3
force-pushed
the
renepay-bugfix-htlctotal
branch
from
4161c2e to
88dcfc9
Compare
In theory we should not have htlc_total<=known_max. But for some strange race condition we do sometimes. Until we find a solution to ensure the correct state of the uncertainty network we remove the assertion. Thanks to signed arithmetic and MIN guards, the rest of the code in linearize_channel can handle the weird cases with known_max<htlc_total. Signed-off-by: Lagrang3 <[email protected]>
- add more checks - add more error messages - compute probabilities without fees during MCF - compute probabilities with fees during get_routes Signed-off-by: Lagrang3 <[email protected]>
Reserved HTLCs were underestimated by floor (mathematical function) use ceil instead. Signed-off-by: Lagrang3 <[email protected]>
Refresh gossmap once before we read the routehints. Make sure that if channels in the routehints are public, we retrieve their capacities from gossip. Signed-off-by: Lagrang3 <[email protected]>
Add a little bit of uncertainty to the local channels to avoid consuming precisely all spendable_msat on our side, which leads to temporary channel failure if the spendable_msat changes during the course of the payment. Signed-off-by: Lagrang3 <[email protected]>
Channel filter must apply to the modified gossmap+localmods, otherwise we disable local channels with htlcmax=0. Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
force-pushed
the
renepay-bugfix-htlctotal
branch
from
88dcfc9 to
bc38f2d
Compare
|
Rebased |
Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
force-pushed
the
renepay-bugfix-htlctotal
branch
from
bc38f2d to
b5f9734
Compare
|
ACK b5f9734 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make knowledge update and removal of pending HTLCs atomic to avoid race conditions.A quick and dirty solution: comment the assertion making sure the rest of the code in
linearize_channelcan handle theoffending cases (for which
known_max<htlc_total).Fixes #7535.