Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Updating SHASUMS for updated zlib1g-dev in Ubuntu Noble #7612

Merged

Conversation

ShahanaFarooqui
Copy link
Collaborator

@ShahanaFarooqui ShahanaFarooqui commented Aug 26, 2024

⚠️ IMPORTANT:

Feature freeze date for v24.08 is Aug 5th.

RC1 is scheduled on Aug 10th, RC2 on Aug 15, ...

The final release is on Aug 22nd.

Issue:

Since we added support for Ubuntu 24.04, it was installing zlib1g-dev version 1:1.3.dfsg-3.1ubuntu2. However zlib released a minor version 1:1.3.dfsg-3.1ubuntu2.1 on Aug 9th.

zlib (1:1.3.dfsg-3.1ubuntu2.1) noble-proposed; urgency=medium

  * SRU: LP: #2076340: No-change rebuild to pick up changed build flags
    on ppc64 and s390x.

Which changed SHASUMS for our noble repro-build.sh and broke the build-release process.

Solution:

1: Either we can update the script with the latest zlib1g-dev SHASUMS Or
2: Lock the zlib1g-dev version to 1:1.3.dfsg-3.1ubuntu2.

For now, I am updating the SHASUMS & version but we can re-consider locking it if the issue keeps repeating in future CLN releases (due to frequent zlib minor version updates).

Changelog-Fixed: core lightning's reproducible build for Ubuntu v24.04 (noble).

Changelog-Fixed: core lightning's reproducible build for Ubuntu v24.04 (noble).
@ShahanaFarooqui ShahanaFarooqui added this to the v24.08 milestone Aug 26, 2024
@niftynei
Copy link
Contributor

ACK 7193f0a

@ShahanaFarooqui ShahanaFarooqui merged commit 48fa438 into ElementsProject:master Aug 27, 2024
38 checks passed
@endothermicdev
Copy link
Collaborator

Had to build with the --no-cache option after this change, i.e., sudo docker build --no-cache -t cl-repro-noble - < contrib/reprobuild/Dockerfile.noble even though I had deleted the previous docker image, but no problems otherwise.
ACK 7193f0a

@s373nZ s373nZ mentioned this pull request Oct 3, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants