Add ‘v’ to the version from zipfile release #8010
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building from a release zipfile and there is no `git` present, the version number lacks a ‘v’. This triggers db.c to fail it’s `is_released_version` check, which fails because the version not start with a ‘v’ — thereby the database upgrade is rejected. Issue reported by TonyV on Discord: “Hey guys, I just upgraded to the latest release and am now getting ``` Refusing to irreversibly upgrade db from version 219 to 261 in non-final version 24.11.1 (use --database-upgrade=true to override) ``` I have the db backed up... but am I good to make those changes without breaking my channels?” Changelog-Changed: Fix for people upgrading using source release zip packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building from a release zipfile and there is no
gitpresent, the version number lacks a ‘v’.This triggers db.c to fail its
is_released_versioncheck, which fails because the version does not start with a ‘v’ — thereby the database upgrade is rejected.Issue reported by TonyV on Discord:
“Hey guys, I just upgraded to the latest release and am now getting
I have the db backed up... but am I good to make those changes without breaking my channels?”
Changelog-Changed: Fix for people upgrading using source release zip packages.