lnd: paying to the payment request #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YusukeShimizu
force-pushed
the
set-payment_request
branch
from
29ae06d to
d437ac5
Compare
Use the SendPaymentV2 RPC and set payment_request in the request. This will ensure that the payments are linked to the peerswap invoices that were paid. I check that the remote pubkey of the channel and the destination of the invoice match. Also added a test case to ensure that payreq is included in the payment.
YusukeShimizu
force-pushed
the
set-payment_request
branch
from
d437ac5 to
8079ab1
Compare
YusukeShimizu
changed the title
mrfelton
reviewed
Feb 9, 2024
mrfelton
approved these changes
Feb 15, 2024
nepet
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use the SendPaymentV2 RPC and set payment_request in the request.
This will ensure that the payments are linked to the peerswap invoices that were paid.
And check that the remote pubkey of the channel and the destination of the invoice match to ensure direct payment.
Also added a test case to ensure that payreq is included in the payment.
Both cln and lnd confirmed to include payreq in payment.
Why
To respond to the request for the lightning payment portion of #254.