Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model JSON ; Prettier format #27

Merged
merged 8 commits into from
Nov 22, 2024
Merged

Fix model JSON ; Prettier format #27

merged 8 commits into from
Nov 22, 2024

Conversation

jiahuei
Copy link
Member

@jiahuei jiahuei commented Nov 21, 2024

No description provided.

@jiahuei jiahuei enabled auto-merge (squash) November 21, 2024 14:23
@michaelfeil
Copy link
Contributor

michaelfeil commented Nov 21, 2024

@jiahuei

Tests: Requires the actual model name as specified by config, without the ellm! If that is an issue, let me know if it makes sense to go back to v1.

jamai = client_cls()
        kwargs = {
            "input": inputs,
            "model": model, # needs to be BAAI/bge-small-en without ELLM
            "encoding_format": "float",
        }

@jiahuei
Copy link
Member Author

jiahuei commented Nov 22, 2024

@jiahuei

Tests: Requires the actual model name as specified by config, without the ellm! If that is an issue, let me know if it makes sense to go back to v1.

jamai = client_cls()
        kwargs = {
            "input": inputs,
            "model": model, # needs to be BAAI/bge-small-en without ELLM
            "encoding_format": "float",
        }

I see, it should still work but requires some changes to how we run CI. tbh the changes are probably needed sooner or later anyway

@jiahuei jiahuei merged commit e4940bc into main Nov 22, 2024
7 checks passed
@jiahuei jiahuei deleted the fix-jh branch November 22, 2024 07:34
@jiahuei
Copy link
Member Author

jiahuei commented Nov 22, 2024

@michaelfeil CI is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants