Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Cleanup #81

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Login Cleanup #81

merged 2 commits into from
Jul 25, 2024

Conversation

Rahkeen
Copy link
Collaborator

@Rahkeen Rahkeen commented Jul 24, 2024

This change request adds a bunch of cleanup after the initial infrastructure was in. Including:

  • Logout
  • A better looking login card in settings
  • Removing default styling on text fields
  • Better IME selection for text entry

Copy link

emerge-tools bot commented Jul 24, 2024

📸 Snapshot Test

3 modified, 5 added, 21 unchanged

Name Version Added Removed Modified Unchanged Errored Approval
Hacker News
com.emergetools.hackernews.debug
1.0 (1) 5 0 3 21 0 ✅ Approved

🛸 Powered by Emerge Tools

Copy link

emerge-tools bot commented Jul 24, 2024

⏱ Performance Analysis

Hacker News

Head build: Hacker News 1.0 (1)
Base build: Hacker News 1.0 (1)

Name Change Comparison
⚠️ Startup (com.emerge.universaltests.EmergeUniversalStartupTest) ⬆️ 5.65% 🛸 View

🛸 Powered by Emerge Tools

Rahkeen added 2 commits July 24, 2024 17:12
This change request adds a bunch of cleanup after the initial infrastructure was in. Including:
- Logout
- A better looking login card in settings
- Removing default styling on text fields
- Better IME selection for text entry
@Rahkeen Rahkeen force-pushed the rikin.login.cleanup branch from da8472c to 82c7a9c Compare July 25, 2024 00:12
@Rahkeen Rahkeen merged commit c6173bd into main Jul 25, 2024
5 of 6 checks passed
@Rahkeen Rahkeen deleted the rikin.login.cleanup branch July 25, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants