Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posting Comments #83

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Posting Comments #83

merged 1 commit into from
Jul 26, 2024

Conversation

Rahkeen
Copy link
Collaborator

@Rahkeen Rahkeen commented Jul 25, 2024

This PR is our initial pass at setting up comments (top level comments, not replies yet)

Added a minimal UI for submitting comments
Modified the CommentsDomain with new state and actions for updating / submitting comments
Extracted out Form Data neccesary for submitting comments
Added a post request to the comment endpoint to tie it all together

@Rahkeen Rahkeen assigned Rahkeen and rbro112 and unassigned Rahkeen Jul 25, 2024
Copy link

emerge-tools bot commented Jul 25, 2024

📸 Snapshot Test

29 unchanged

Name Version Added Removed Modified Unchanged Errored Approval
Hacker News
com.emergetools.hackernews.debug
1.0 (1) 0 0 0 29 0 N/A

🛸 Powered by Emerge Tools

This PR is our initial pass at setting up comments (top level comments, not replies yet)

Added a minimal UI for submitting comments
Modified the `CommentsDomain` with new state and actions for updating / submitting comments
Extracted out Form Data neccesary for submitting comments
Added a post request to the comment endpoint to tie it all together

A couple of updates:

Cleaned up Web Client + Domain a bit
Re-route post upvote to login if not logged in
Re-route actions to Login if you aren't logged in
Observing Login State by Combining Flows
@Rahkeen Rahkeen force-pushed the rikin.adding-comments branch from 98a6258 to a56c432 Compare July 26, 2024 21:38
@Rahkeen Rahkeen merged commit 899a57d into main Jul 26, 2024
5 checks passed
@Rahkeen Rahkeen deleted the rikin.adding-comments branch July 26, 2024 22:15
Rahkeen added a commit that referenced this pull request Aug 8, 2024
This PR is our initial pass at setting up comments (top level comments,
not replies yet)

Added a minimal UI for submitting comments
Modified the `CommentsDomain` with new state and actions for updating /
submitting comments
Extracted out Form Data neccesary for submitting comments
Added a post request to the comment endpoint to tie it all together
Rahkeen added a commit that referenced this pull request Aug 8, 2024
This PR is our initial pass at setting up comments (top level comments,
not replies yet)

Added a minimal UI for submitting comments
Modified the `CommentsDomain` with new state and actions for updating /
submitting comments
Extracted out Form Data neccesary for submitting comments
Added a post request to the comment endpoint to tie it all together
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants