Add a Full Cube mask to mask to blocks that fill an entire cube #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...core/src/main/java/com/sk89q/worldedit/extension/factory/parser/mask/FullCubeMaskParser.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/function/mask/FullCubeMask.java
Outdated
Show resolved
Hide resolved
me4502
force-pushed
the
feature/fullcube-mask
branch
from
5f8eb5d to
cb5521b
Compare
wizjany
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mask (
#fullcube) that masks to anything that fits the "isFullCube" material property. This is distinct from the solid check, which includes blocks that don't quite fill the cube. Oddly, the solid check includes blocks that fill more than0.7291666666666666of the bounds of a block, which means stairs, etc are all included. fullblock would only include blocks that are exactly the bounds of the block.This PR somewhat ideally needs #2447, which implements this check everywhere.