Fix description #344
Merged
Fix description #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version used only "product" instead of also checking "description". Also used "Name" as fall back as well.
New version takes "description" first, falls back to "product", and do not use "Name" for the description ("Name" is already stored as a synonym).
JAlvarezJarreta
requested changes
Apr 15, 2024
Co-authored-by: J. Alvarez-Jarreta <[email protected]>
JAlvarezJarreta
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an important fix to properly use the "description" field instead of only "product" or "Name". Now the "description" is used by default, with a fallback to "product". The "Name" is now only stored as synonym.
Also included: