Update compare fasta files #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
There was a problem hiding this comment.
I would add triple quotes description of module here, then use doc in main() description to point to this description.
ens-LCampbell
requested changes
Jan 10, 2025
| Returns: | ||
| argparse.Namespace: Parsed arguments as an argparse Namespace object. | ||
| """ | ||
| parser = ArgumentParser(description="Compare sequences between two genomes") |
There was a problem hiding this comment.
Remove Compare sequences between two genomes, replace with __doc__
Additionally, Id recommend briefly touching on what is the basis of said comparison just to make the description of the module a little clearer without digging into each diff function.
| default=Path.cwd(), | ||
| help="Directory to store the comparison report. Defaults to the current working directory.", | ||
| ) | ||
|
|
There was a problem hiding this comment.
remove empty line new line break
| action="store_true", | ||
| help="Enable compare seq_region mode, i.e. use seq_region for seqence comparison", | ||
| ) | ||
| return parser.parse_args(arg_list) |
There was a problem hiding this comment.
Before return of parser, don't forgot to add parser.add_log_arguments()
shradhaebi
reviewed
Jan 21, 2025
| """ | ||
| Compare two FASTA files for common, unique, and differing sequences. | ||
| """ | ||
|
|
There was a problem hiding this comment.
May be a comment to add "Reading fasta" like in below cases ?
Co-authored-by: Lahcen Campbell <[email protected]>
Co-authored-by: Lahcen Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated compare fasta from runnables into a module. This module is mainly focused on comparing 2 fasta files, mainly with INSDC