Group constants for commutative ops #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Feb 1, 2025
| auto lhs = op.getLhs(); | ||
| auto rhs = op.getRhs(); | ||
|
|
||
| auto lhsConst = lhs.template getDefiningOp<stablehlo::ConstantOp>(); |
There was a problem hiding this comment.
can you do this as a matchPattern like for other constants above?
wsmoses
reviewed
Feb 1, 2025
| @@ -2922,6 +2922,56 @@ struct AddSimplify : public OpRewritePattern<mlir::stablehlo::AddOp> { | |||
| } | |||
| }; | |||
|
|
|||
| // ((add x cst0) cst1) -> (add x1 (add cst0 cst1)) | |||
| template <typename T> struct BinOpConstSimplify : public OpRewritePattern<T> { | |||
| using OpRewritePattern<T>::OpRewritePattern; | |||
There was a problem hiding this comment.
you should template this with a fastmath flag, since while this is always valid for ints, for floats this may violate IEEE standards
There was a problem hiding this comment.
I applied only to integers for now.
Enzyme-JAX/src/enzyme_ad/jax/Passes/EnzymeHLOOpt.cpp
Lines 2931 to 2933 in 06eb601
There was a problem hiding this comment.
Fair nuff, open an issue for extending to floats?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297.