Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling memmove warning #1637

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Allow disabling memmove warning #1637

merged 1 commit into from
Jan 26, 2024

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jan 26, 2024

No description provided.

@wsmoses wsmoses requested a review from ZuseZ4 January 26, 2024 00:51
ZuseZ4
ZuseZ4 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@ZuseZ4 ZuseZ4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a way to solve this. ^^
I don't remember why this was so hard to fix, can you please write it down somewhere?

@wsmoses
Copy link
Member Author

wsmoses commented Jan 26, 2024

I mean it is a warning that the implementation for aliasing pointers in memmove is not correct with this derivative (in a very specific case).

@ZuseZ4
Copy link
Member

ZuseZ4 commented Jan 26, 2024

Ah, it was aliasing. Fair, then I don't mind. #noalias

@wsmoses wsmoses merged commit af10cc9 into main Jan 26, 2024
32 of 54 checks passed
@wsmoses wsmoses deleted the memmove branch January 26, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZuseZ4 ZuseZ4 ZuseZ4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsmoses @ZuseZ4