Automatic function call insertion #523

jumerckx · 2025-01-13T08:34:58Z

on top of: #366, currently has an error:

using Reactant

Reactant.DEBUG_INTERP[] = true
Reactant.TOGGLE_TRACECALLS[] = true # necessary to avoid precompilation from failing

@noinline _call1(a, b) = a
function call1(a, b)
    x = _call1(a, b)
    y = _call1(a, b)
    return _call1(x, y)
end

a = rand(2, 3)
b = rand(2, 3)
a_ra = Reactant.to_rarray(a)
b_ra = Reactant.to_rarray(b)

@compile(call1(a_ra, b_ra))

ERROR: StackOverflowError:
Stacktrace:
     [1] make_typealias(x::Type)
       @ Base ./show.jl:644
     [2] show_typealias(io::IOBuffer, x::Type)
       @ Base ./show.jl:805
     [3] _show_type(io::IOBuffer, x::Type)
       @ Base ./show.jl:970
     [4] show(io::IOBuffer, x::Type)
       @ Base ./show.jl:965
     [5] show_typeparams(io::IOBuffer, env::Core.SimpleVector, orig::Core.SimpleVector, wheres::Vector{TypeVar})
       @ Base ./show.jl:722
     [6] show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar})
       @ Base ./show.jl:1181
     [7] show_datatype
       @ ./show.jl:1089 [inlined]
     [8] _show_type(io::IOBuffer, x::Type)
       @ Base ./show.jl:973
     [9] show(io::IOBuffer, x::Type)
       @ Base ./show.jl:965
    [10] _show_default(io::IOBuffer, x::Any)
       @ Base ./show.jl:486
    [11] show_default
       @ ./show.jl:482 [inlined]
    [12] show
       @ ./show.jl:477 [inlined]
    [13] print(io::IOBuffer, x::Base.Generator{Vector{Pair{Any, Any}}, Reactant.var"#1#3"})
       @ Base ./strings/io.jl:35
    [14] print_to_string(xs::Base.Generator{Vector{Pair{Any, Any}}, Reactant.var"#1#3"})
       @ Base ./strings/io.jl:148
    [15] string
       @ ./strings/io.jl:189 [inlined]
    [16] safe_print
       @ ~/Reactant.jl/src/utils.jl:448 [inlined]
    [17] OrderedDict
       @ ~/.julia/packages/OrderedCollections/5e4BO/src/ordered_dict.jl:27 [inlined]
    [18] call_with_reactant(::Type{OrderedCollections.OrderedDict{…}}, ::Base.Generator{Vector{…}, Reactant.var"#1#3"})
       @ Reactant ~/Reactant.jl/src/utils.jl:0
    [19] OrderedIdDict
       @ ~/Reactant.jl/src/OrderedIdDict.jl:8 [inlined]
    [20] OrderedIdDict
       @ ~/Reactant.jl/src/OrderedIdDict.jl:16 [inlined]
    [21] OrderedIdDict
       @ ~/Reactant.jl/src/OrderedIdDict.jl:15 [inlined]
    [22] traced_call
       @ ~/Reactant.jl/src/ControlFlow.jl:134 [inlined]
    [23] traced_call(none::typeof(memoryref), none::Tuple{Memory{UInt64}})
       @ Reactant ./<missing>:0
    [24] GenericMemory
       @ ./boot.jl:514 [inlined]
    [25] Array
       @ ./boot.jl:578 [inlined]
    [26] getindex
       @ ./array.jl:400 [inlined]
    [27] OrderedIdDict
       @ ~/Reactant.jl/src/OrderedIdDict.jl:16 [inlined]
    [28] OrderedIdDict
       @ ~/Reactant.jl/src/OrderedIdDict.jl:15 [inlined]
    [29] traced_call
       @ ~/Reactant.jl/src/ControlFlow.jl:134 [inlined]
    [30] call_with_reactant(::typeof(ReactantCore.traced_call), ::typeof(memoryref), ::Memory{UInt64})
       @ Reactant ~/Reactant.jl/src/utils.jl:0
    [31] traced_call_with_reactant(f::Function, args::Memory{UInt64})
       @ Reactant ~/Reactant.jl/src/utils.jl:19
    [32] Array
       @ ./boot.jl:579 [inlined]
    [33] Array
       @ ./boot.jl:601 [inlined]
    [34] OrderedDict
       @ ~/.julia/packages/OrderedCollections/5e4BO/src/ordered_dict.jl:23 [inlined]
    [35] OrderedCollections.OrderedDict{UInt64, Any}()
       @ Reactant ./<missing>:0
    [36] GenericMemory
       @ ./boot.jl:516 [inlined]
    [37] Array
       @ ./boot.jl:578 [inlined]
    [38] Array
       @ ./boot.jl:591 [inlined]
    [39] zeros
       @ ./array.jl:589 [inlined]
    [40] zeros
       @ ./array.jl:585 [inlined]
    [41] OrderedDict
       @ ~/.julia/packages/OrderedCollections/5e4BO/src/ordered_dict.jl:23 [inlined]
    [42] call_with_reactant(redub_arguments#232::Type{OrderedCollections.OrderedDict{UInt64, Any}})
       @ Reactant ~/Reactant.jl/src/utils.jl:0
    [43] traced_call
       @ ~/Reactant.jl/lib/ReactantCore/src/ReactantCore.jl:397 [inlined]
    [44] traced_call(none::Type{OrderedCollections.OrderedDict{UInt64, Any}}, none::Tuple{})
       @ Reactant ./<missing>:0
    [45] traced_call
       @ ~/Reactant.jl/lib/ReactantCore/src/ReactantCore.jl:397 [inlined]
    [46] call_with_reactant(::typeof(ReactantCore.traced_call), ::Type{OrderedCollections.OrderedDict{UInt64, Any}})
       @ Reactant ~/Reactant.jl/src/utils.jl:0
    [47] traced_call_with_reactant(::Type)
       @ Reactant ~/Reactant.jl/src/utils.jl:0
    [48] OrderedDict
       @ ~/.julia/packages/OrderedCollections/5e4BO/src/ordered_dict.jl:27 [inlined]
    [49] OrderedCollections.OrderedDict{UInt64, Any}(none::Base.Generator{Vector{Pair{Any, Any}}, Reactant.var"#1#3"})
       @ Reactant ./<missing>:0
--- the above 33 lines are repeated 2284 more times ---
...

With debug printing eventually just repeating:

...
"fn arg[1] traced_call"
"fn arg[2] memoryref"
"fn arg[3] (UInt64[],)"
"fn arg[1] memoryref"
"fn arg[2] Pair{Any, Any}[]"
"fn arg[1] OrderedCollections.OrderedDict{UInt64, Any}"
"fn arg[2] Base.Generator{Vector{Pair{Any, Any}}, Reactant.var\"#1#3\"}(Reactant.var\"#1#3\"(), Pair{Any, Any}[])"
"fn arg[1] traced_call"
"fn arg[2] OrderedCollections.OrderedDict{UInt64, Any}"
"fn arg[3] ()"
"fn arg[1] OrderedCollections.OrderedDict{UInt64, Any}"
...

As if there's a cycle in the callgraph?

…ed values to their corresponding mlir type. These transformed values can be used as keys in a dict (stored in ScopedValue for ease). Cache hits are detected but the cache is not yet used because there is not yet a way to replace the mlir data recursively in a traced object.

Repurposes the path argument of `make_tracer` and builds a vector containing: * MLIR type for traced values * Julia type for objects * actual value for primitive types * `VisitedObject(id)` for objects that where already encountered ( == stored in `seen`).

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/test/control_flow.jl

Line 585 in d2ce359

ir = @code_hlo optimize=false call1(a_ra, b_ra)

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/test/control_flow.jl

Line 594 in d2ce359

ir = @code_hlo optimize=false call1(a_ra, c_ra)

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/test/control_flow.jl

Line 599 in d2ce359

_call2(a) = a+a

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/test/control_flow.jl

Line 629 in d2ce359

ir = @code_hlo optimize=false call3(y_ra)

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/test/control_flow.jl

Line 641 in d2ce359

_call4(foobar::Union{Foo, Bar}) = foobar.x

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/test/control_flow.jl

Line 654 in d2ce359

ir = @code_hlo optimize=false call4(foo, foo2, bar)

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/test/control_flow.jl

Line 658 in d2ce359

wsmoses · 2025-01-16T04:03:40Z

src/utils.jl

@@ -257,11 +274,12 @@ function rewrite_inst(inst, ir, interp, RT, guaranteed_error)
                end
            end
        elseif Base.invokelatest(should_rewrite_ft, ft)
+            new_f = (!allow_tracing || ft <: typeof(ReactantCore.traced_call)) ? call_with_reactant : traced_call_with_reactant


So I see what's happening here, but I feel like we should do this a bit differently.

Presently you're rewriting all calls to be traced_call_with_reactant.

What if, instead, we modified the codeinfo and/or opaque closure within call_with_reactant. That way we don't have an extra level of indirection (that may cause issues)

We already have the methodinstance/codeinfo on the inside (and argtypes themselves) so we could even do the equivalent of make_Tracer into a compile-time recusion (aka generate the equivalent of

key = (arg1.x.y, arg2.z, arg3[4], ...)

during the generated function, so then the (relatively expensive) make_tracer isn't called every function call (which is already quite expensive).

Also therefore if a function just is foo(TracedArray, ) we literally don't even need to do a key check!

For my understanding:

8 1 ─ %1 = invoke Main._call1(_2::Reactant.TracedRArray{Float64, 2}, _3::Reactant.TracedRArray{Float64, 2})::Reactant.TracedRArray{Float64, 2} 9 │ %2 = invoke Main._call1(%1::Reactant.TracedRArray{Float64, 2}, %1::Reactant.TracedRArray{Float64, 2})::Reactant.TracedRArray{Float64, 2} └── return %2

would need to be rewritten to:

%1 = (call_with_reactant)(traced_call, _call1, _2, _3) %2 = (call_with_reactant)(traced_call, _call1, %1, %1) return %2

instead of (traced_call_with_reactant)(_call1, ...), or do you mean to remove more indirection still?

so we could even do the equivalent of make_Tracer into a compile-time recusion

Maybe I'm misunderstanding your point, but I don't think we can fully do the equivalent of make_tracer at compile-time?
e.g.

struct A x #untyped end

For arguments of type A we can generate arg.x but we can't go deeper than that?

yeah it depends on the type, maybe we can talk about it tomorrow/over the weekend

To make it easier to use those parts in `call_with_reactant_generator`.

Caching is not yet enabled, and arguments aren't passed correctly yet.

jumerckx · 2025-01-22T11:17:05Z

A problem when tracing through broadcasting:
Base.similar for broadcasted objects is implemented as

function Base.similar(
    ::Broadcasted{AbstractReactantArrayStyle{N}}, ::Type{T}, dims
) where {T<:ReactantPrimitive,N}
    @assert N isa Int
    return TracedRArray{T,length(dims)}((), nothing, map(length, dims))
end

This creates an "temporarily invalid" TracedRArray since there's no mlir data.
With regular tracing, this was no problem because these calls are always paired with Base.copyto! which injects the correct MLIR data.
When trying to generate the calls separately, however, there is no actual mlir value which can be used to be passed to the mlir version of copyto!.

Possible solutions:

make similar for broadcasted objects return an actual mlir value (fill(0, ...))
automatically replace "invalid" objects with a tensor of zeros at the point where they would be used as arguments for a call
...?

To me, the first approach seems more correct, in the sense that the implementation for similar of broadcasted objects can actually be used as a standalone function.

wsmoses · 2025-01-22T15:10:07Z

first seems cleaner to me

github-actions · 2025-02-06T16:09:09Z

src/Compiler.jl

@@ -467,7 +467,9 @@ function compile_mlir!(
    fnwrapped,
    func2, traced_result, result, seen_args, ret, linear_args, in_tys,
    linear_results = try
-        Reactant.TracedUtils.make_mlir_fn(f, args, (), "main", true)
+        callcache!(callcache) do # TODO: don't create a closure here either.
+          Reactant.TracedUtils.make_mlir_fn(f, args, (), "main", true)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

Reactant.TracedUtils.make_mlir_fn(f, args, (), "main", true)

Reactant.TracedUtils.make_mlir_fn(f, args, (), "main", true)

github-actions · 2025-02-06T16:09:09Z

src/TracedUtils.jl

+function placeholder_func(
+    name, linear_args, toscalar, do_transpose, concretein
+)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

function placeholder_func(

name, linear_args, toscalar, do_transpose, concretein

)

function placeholder_func(name, linear_args, toscalar, do_transpose, concretein)

github-actions · 2025-02-06T16:09:10Z

src/utils.jl

+    do_transpose = false
+
+    name = String(nameof(f))
+


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2025-02-06T16:09:10Z

src/utils.jl

+        v isa TracedType || continue
+        push!(mlir_caller_args, v.mlir_data)
+        # make tracer inserted `()` into the path, here we remove it:
+        v.paths = v.paths[1:end-1]


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

v.paths = v.paths[1:end-1]

v.paths = v.paths[1:(end - 1)]

github-actions · 2025-02-06T16:09:10Z

src/utils.jl

+        # make tracer inserted `()` into the path, here we remove it:
+        v.paths = v.paths[1:end-1]
+    end
+


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2025-02-06T20:53:11Z

src/TracedUtils.jl

+    result,
+    traced_args,
+    linear_args,
+    fnbody,
+    concretein,
+    args_in_result,
+    do_transpose,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

result,

traced_args,

linear_args,

fnbody,

concretein,

args_in_result,

do_transpose,

result, traced_args, linear_args, fnbody, concretein, args_in_result, do_transpose

github-actions · 2025-02-06T20:53:11Z

src/TracedUtils.jl

+    fnbody,
+    linear_results,
+    args_in_result,
+    do_transpose,
+    return_dialect,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

fnbody,

linear_results,

args_in_result,

do_transpose,

return_dialect,

fnbody, linear_results, args_in_result, do_transpose, return_dialect

github-actions · 2025-02-06T20:53:11Z

src/TracedUtils.jl

+    seen_args, traced_args, linear_args = prepare_args(
+        args, concretein, toscalar
+    )


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

seen_args, traced_args, linear_args = prepare_args(

args, concretein, toscalar

)

seen_args, traced_args, linear_args = prepare_args(args, concretein, toscalar)

github-actions · 2025-02-06T20:53:11Z

src/TracedUtils.jl

+        name,
+        linear_args,
+        toscalar,
+        do_transpose,
+        concretein,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

name,

linear_args,

toscalar,

do_transpose,

concretein,

name, linear_args, toscalar, do_transpose, concretein

github-actions · 2025-02-06T20:53:11Z

src/TracedUtils.jl

+        result,
+        traced_args,
+        linear_args,
+        fnbody,
+        concretein,
+        args_in_result,
+        do_transpose,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

result,

traced_args,

linear_args,

fnbody,

concretein,

args_in_result,

do_transpose,

result, traced_args, linear_args, fnbody, concretein, args_in_result, do_transpose

github-actions · 2025-02-06T20:53:11Z

src/TracedUtils.jl

+        fnbody,
+        linear_results,
+        args_in_result,
+        do_transpose,
+        return_dialect,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

fnbody,

linear_results,

args_in_result,

do_transpose,

return_dialect,

fnbody, linear_results, args_in_result, do_transpose, return_dialect

github-actions · 2025-02-07T15:36:33Z

src/utils.jl

+        name,
+        linear_args,
+        toscalar,
+        do_transpose,
+        concretein,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

name,

linear_args,

toscalar,

do_transpose,

concretein,

name, linear_args, toscalar, do_transpose, concretein

github-actions · 2025-02-07T15:36:33Z

src/utils.jl

+        do_transpose,
+        concretein,
+    )
+


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2025-02-07T15:36:33Z

src/utils.jl

+    )
+
+    MLIR.IR.activate!(fnbody)
+


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2025-02-07T15:36:33Z

src/utils.jl

+    Core.println("##############################")
+    Core.println("CALLER ARGS: $mlir_caller_args")
+    Core.println("##############################")
+    return mod, temp_func, in_tys, fnbody, sym_visibility, mlir_caller_args, traced_args, linear_args, name


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

return mod, temp_func, in_tys, fnbody, sym_visibility, mlir_caller_args, traced_args, linear_args, name

return mod,

temp_func,

in_tys,

fnbody,

sym_visibility,

mlir_caller_args,

traced_args,

linear_args,

name

github-actions · 2025-02-07T15:36:33Z

src/utils.jl

+    return mod, temp_func, in_tys, fnbody, sym_visibility, mlir_caller_args, traced_args, linear_args, name
+end
+
+@inline get_traced_args_from_temp1((mod, temp_func, in_tys, fnbody, sym_visibility, mlir_caller_args, traced_args, linear_args, name)) = traced_args


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

@inline get_traced_args_from_temp1((mod, temp_func, in_tys, fnbody, sym_visibility, mlir_caller_args, traced_args, linear_args, name)) = traced_args

@inline get_traced_args_from_temp1((

mod,

temp_func,

in_tys,

fnbody,

sym_visibility,

mlir_caller_args,

traced_args,

linear_args,

name,

)) = traced_args

github-actions · 2025-02-07T15:36:34Z

src/utils.jl

+        push!(overdubbed_code, Expr(:call, temp1, fn_args...))
+        push!(overdubbed_codelocs, code_info.codelocs[1])
+        temp1_output = Core.SSAValue(length(overdubbed_code))
+


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2025-02-07T15:36:34Z

src/utils.jl

+        push!(overdubbed_code, Expr(:call, get_traced_args_from_temp1, temp1_output))
+        push!(overdubbed_codelocs, code_info.codelocs[1])
+        traced_args = Core.SSAValue(length(overdubbed_code))
+


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2025-02-07T15:36:34Z

src/utils.jl

+        push!(overdubbed_codelocs, code_info.codelocs[1])
+    else
+        push!(overdubbed_code, Expr(:call, oc, fn_args[2:end]...))
+        push!(overdubbed_codelocs, code_info.codelocs[1])        


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

push!(overdubbed_codelocs, code_info.codelocs[1])

push!(overdubbed_codelocs, code_info.codelocs[1])

github-actions · 2025-02-07T15:36:34Z

src/utils.jl

+
+

[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2025-02-07T15:36:34Z

src/utils.jl

+    if TRACE_CALLS[]
+        push!(overdubbed_code, Expr(:call, temp2, ocres, temp1_output))
+        push!(overdubbed_codelocs, code_info.codelocs[1])
+


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

jumerckx · 2025-02-12T22:03:36Z

When tracing through this function:
https://github.com/EnzymeAD/Reactant.jl/blob/467559dacc1f01db63771bdfaf58eb5a4714a312/src/TracedRArray.jl#L772C1-L773C1
Somewhere in the callgraph of collect(TracedUtils.get_mlir_data.(X)) is a call to something similar to:

function f(X::TracedRArray)
	return (X.get_mlir_data, ) # MLIR values, not TracedRArrays -> Considered "not part of" the Reactant tracing
end

i.e., a function that takes a tracedrarray and returns a tuple of MLIR values.

The automatic call insertion currently maps all TracedRArray arguments onto mlir function arguments. Similarly, TracedRArray return values are updated once returned to the caller scope, to contain the result of the func.call instead of the mlir value from the callee scope.

Here, however, this leads to buggy code:
X is mapped onto block arg 0 in the callee, but when the MLIR value is returned, it is not a TracedRArray, but an MLIR value—part of Julia land.
As a result, the return result is not mapped back on the func.call result but instead keeps referring to block arg from the callee scope.

A straightforward solution would be to have an option to disable Reactant tracing as discussed in the call today. This requires the user code to be changed, though, so I'm wondering if there's a possibility to handle this case automatically?
Curious to hear what your thoughts are on this, @wsmoses.

wsmoses · 2025-02-12T22:07:18Z

I'd consider there to be two classes of functions:

User and helper code that uses tracedrarray's/etc
Ops, and other manual code that takes mlir values

We should handle the first and not the second (and I'm surprised we didn't mark that existing function as noinline and not to be re-interpreter'd on the inside)

jumerckx · 2025-02-12T22:16:05Z

and I'm surprised we didn't mark that existing function as noinline and not to be re-interpreter'd on the inside

Right, so the solution is just to move part of that function to an Op?

wsmoses · 2025-02-12T22:17:20Z

yeah like Ops.concat or something

jumerckx and others added 25 commits January 2, 2025 14:53

wip trace function call

533a19d

multiple return values

04690e8

add enable_tracing scopedvalue

caf0e0e

wip

dbf1dac

caching!

d914f04

add ScopedValues as a dependency

670a8c5

actually use ScopedValues...

48be2e9

properly handle arg and result tracedvalues in traced_call

ae8701d

don't tranpose results when do_tranpose=false

c40e585

a few tests

531d1b2

CallCache mode: support TracedRNumber

f0723e8

one more test

5ead000

add Cached object with custom equality and hash for use a dict key

1f05bc9

caching test

e1852c5

fix

0cea97a

callcache

38e098c

add deepcopy to Cached constructor

236babf

within_tracing, approach taken from Enzyme.jl

2c87ddc

make callcache a default arg

ccb585f

within_tracing --> within_compile

469a2ff

TracedToTypes tracing mode.

84dd0d1

Repurposes the path argument of `make_tracer` and builds a vector containing: * MLIR type for traced values * Julia type for objects * actual value for primitive types * `VisitedObject(id)` for objects that where already encountered ( == stored in `seen`).

remove ScopedValues from Project.toml

39b07c9

Merge branch 'main' into jm/funccall

af8ac2d

Merge branch 'main' into jm/funccall

739977c

github-actions bot reviewed Jan 13, 2025

View reviewed changes

wsmoses reviewed Jan 16, 2025

View reviewed changes

jumerckx added 3 commits January 22, 2025 10:36

support broadcasted calls in @trace

a34a228

initial attemt at automatic function call tracing

be583d2

revert changes to utils

541529d

jumerckx added 4 commits January 22, 2025 10:37

split make_mlir_fn into pieces

77209af

To make it easier to use those parts in `call_with_reactant_generator`.

insert setup and breakdown around execution of the oc.

6bae476

Caching is not yet enabled, and arguments aren't passed correctly yet.

WIP

7d53410

doesn't cache, and no broadcasting yet (and code cleanup still required)

a27294e

jumerckx force-pushed the jm/funccal_insertion branch from 0dacb36 to a27294e Compare January 22, 2025 09:38

jumerckx mentioned this pull request Jan 26, 2025

make similar return empty tensors. #632

Merged

Merge branch 'main' into jm/funccal_insertion

390b4fd

github-actions bot reviewed Feb 6, 2025

View reviewed changes

fixup merge commit

a509164

github-actions bot reviewed Feb 6, 2025

View reviewed changes

small fixes

f082c7a

github-actions bot reviewed Feb 7, 2025

View reviewed changes

jumerckx added 7 commits February 9, 2025 22:09

fix mutation handling

6f078f7

fix more uninitialized tracedrarray construction

f394381

handle make_tracer of memory

e8cd78d

debugging stuff

6fb74d5

remove debugging stuff

e07ef73

move __lookup_unique_name_in_module out of final_func!

bfcdd35

fix

69b9ff0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatic function call insertion #523

Automatic function call insertion #523

jumerckx commented Jan 13, 2025 •

edited

Loading

github-actions bot left a comment

wsmoses Jan 16, 2025

wsmoses Jan 16, 2025

wsmoses Jan 16, 2025

jumerckx Jan 16, 2025

wsmoses Jan 17, 2025

jumerckx commented Jan 22, 2025

wsmoses commented Jan 22, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 6, 2025

github-actions bot Feb 7, 2025

github-actions bot Feb 7, 2025

github-actions bot Feb 7, 2025

github-actions bot Feb 7, 2025

github-actions bot Feb 7, 2025

github-actions bot Feb 7, 2025

github-actions bot Feb 7, 2025

github-actions bot Feb 7, 2025

github-actions bot Feb 7, 2025

github-actions bot Feb 7, 2025

jumerckx commented Feb 12, 2025

wsmoses commented Feb 12, 2025

jumerckx commented Feb 12, 2025

wsmoses commented Feb 12, 2025

	Reactant.TracedUtils.make_mlir_fn(f, args, (), "main", true)
	Reactant.TracedUtils.make_mlir_fn(f, args, (), "main", true)

	push!(overdubbed_codelocs, code_info.codelocs[1])
	push!(overdubbed_codelocs, code_info.codelocs[1])

Automatic function call insertion #523

Are you sure you want to change the base?

Automatic function call insertion #523

Conversation

jumerckx commented Jan 13, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

wsmoses Jan 16, 2025

Choose a reason for hiding this comment

wsmoses Jan 16, 2025

Choose a reason for hiding this comment

wsmoses Jan 16, 2025

Choose a reason for hiding this comment

jumerckx Jan 16, 2025

Choose a reason for hiding this comment

wsmoses Jan 17, 2025

Choose a reason for hiding this comment

jumerckx commented Jan 22, 2025

wsmoses commented Jan 22, 2025

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

github-actions bot Feb 7, 2025

Choose a reason for hiding this comment

jumerckx commented Feb 12, 2025

wsmoses commented Feb 12, 2025

jumerckx commented Feb 12, 2025

wsmoses commented Feb 12, 2025

jumerckx commented Jan 13, 2025 •

edited

Loading