CPU backend #647
Merged
CPU backend #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @giordano |
Merged
giordano
approved these changes
Jan 29, 2025
src/Compiler.jl
Outdated
| elseif backend == "CPU" | ||
| backend = "cpu" | ||
| end | ||
| @show backend |
There was a problem hiding this comment.
or rather "curreently being debugged print" :P
avik-pal
reviewed
Jan 29, 2025
|
On macOS: $ nm /Users/mose/.julia/artifacts/f3d3555e5fc223023219f21123197e90fa208f2d/lib/libReactantExtra.dylib | grep ClientGetPlatformName
000000000000472c t _ClientGetPlatformNameLowercase |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@avik-pal was that fn not marked exported? |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
avik-pal
reviewed
Jan 30, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| end | ||
| end | ||
|
|
||
| if device_ordinal < 0 | ||
| device_ordinal = XLA.DeviceToClientDeviceOrdinal(device) | ||
| end | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
1031
to
1034
| exec = XLA.Compile( | ||
| client, | ||
| mod; | ||
| device_ordinal, | ||
| num_replicas=1, | ||
| num_partitions=1, | ||
| use_shardy_partitioner=false, | ||
| mod | ||
| ) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| exec = XLA.Compile( | |
| client, | |
| mod; | |
| device_ordinal, | |
| num_replicas=1, | |
| num_partitions=1, | |
| use_shardy_partitioner=false, | |
| mod | |
| ) | |
| exec = XLA.Compile(client, mod) |
Comment on lines
564
to
567
| function Compile( | ||
| client::Client, | ||
| mod::MLIR.IR.Module; | ||
| device_ordinal::Int=-1, | ||
| num_replicas::Int=1, | ||
| num_partitions::Int=1, | ||
| use_shardy_partitioner::Bool=false, | ||
| mod::MLIR.IR.Module | ||
| ) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function Compile( | |
| client::Client, | |
| mod::MLIR.IR.Module; | |
| device_ordinal::Int=-1, | |
| num_replicas::Int=1, | |
| num_partitions::Int=1, | |
| use_shardy_partitioner::Bool=false, | |
| mod::MLIR.IR.Module | |
| ) | |
| function Compile(client::Client, mod::MLIR.IR.Module) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naturally, requires jll update.
But enables us to run GPU kernels on CPU (without a cuda device)