fix off-by-one size restriction in string chunk allocation; apply sam…

…e fixes to ctrl entity string allocator
EpicGamesExt · Jan 6, 2025 · bc44f58 · bc44f58
1 parent d70ce64
commit bc44f58
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/ctrl/ctrl_core.c b/src/ctrl/ctrl_core.c
@@ -676,7 +676,7 @@ ctrl_entity_string_alloc(CTRL_EntityStore *store, String8 string)
           n != 0;
           prev = n, n = n->next)
       {
-        if(n->size >= string.size+1)
+        if(n->size >= string.size)
         {
           if(prev == 0)
           {
@@ -711,6 +711,7 @@ ctrl_entity_string_alloc(CTRL_EntityStore *store, String8 string)
     }
     U8 *chunk_memory = push_array(store->arena, U8, chunk_size);
     node = (CTRL_EntityStringChunkNode *)chunk_memory;
+    node->size = chunk_size;
   }
 
   // rjf: fill string & return

diff --git a/src/raddbg/raddbg_core.c b/src/raddbg/raddbg_core.c
@@ -1126,7 +1126,7 @@ rd_name_alloc(String8 string)
             n != 0;
             prev = n, n = n->next)
         {
-          if(n->size >= string.size+1)
+          if(n->size >= string.size)
           {
             if(prev == 0)
             {