Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added multiple things #142

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

added multiple things #142

wants to merge 8 commits into from

Conversation

bymedeu
Copy link
Contributor

@bymedeu bymedeu commented Oct 24, 2024

Since last time i have:

  • renamed every "Maths" folder in "Maths PC" since a new maths subject was added last year, and will soon be on past exams
  • added almost every subject of the s3 2028 midterm, exept "Ethique", English, "THLR"
  • added the correction of both math subjects
    I might have forgotten to pull and force merge some things, so not sure if your last commit is still on my branch

@bymedeu
Copy link
Contributor Author

bymedeu commented Oct 24, 2024

Seems like the compress PDF files commit worked :)

Copy link
Member

@matiboux matiboux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this was a pain to review (and I procrastinated a lot, I admit — damn, a month already?).

Next time, please update (merge) your branch with upstream (Epidocs:master) for more readable changelogs. Currently, the files changelog shows new changes as well as changes from your last merged PR because it was not updated since. TLDR: Too much diff with upstream branch.

However, that's not the issue preventing me from merging right now, which is:

Upon review, I've noticed the large added file S3/Midterms/Algo/2028/midterm-2028-s3-algo-subject.pdf. Please compress this file! You can use the provided script in the repo, or external online compression tools.

Still, thank you for your contribution!

@matiboux matiboux self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants