-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added multiple things #142
base: master
Are you sure you want to change the base?
Conversation
Cherry-picks & amends 0d0c09f
i am lost in github i forgot to pull pls github god help me
Seems like the compress PDF files commit worked :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this was a pain to review (and I procrastinated a lot, I admit — damn, a month already?).
Next time, please update (merge) your branch with upstream (Epidocs:master
) for more readable changelogs. Currently, the files changelog shows new changes as well as changes from your last merged PR because it was not updated since. TLDR: Too much diff with upstream branch.
However, that's not the issue preventing me from merging right now, which is:
Upon review, I've noticed the large added file S3/Midterms/Algo/2028/midterm-2028-s3-algo-subject.pdf
. Please compress this file! You can use the provided script in the repo, or external online compression tools.
Still, thank you for your contribution!
Since last time i have:
I might have forgotten to pull and force merge some things, so not sure if your last commit is still on my branch