[bugfix] Don't trigger analyzer without enabled checkers #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes users want to execute exactly one checker. This can be done by disabling all checkers and then enabling that one. Some analyzers fail if no checker is enabled. For example, if the user wants to enable one ClangSA checker and disable everything else explicitly, then ClangTidy fails. After this patch an analyzer will not be triggered if all of its checkers are disabled.
bruntib
added
CLI 💻
Szelethus
reviewed
Jul 27, 2023
| no_checker_analyzers = \ | ||
| [a for a in analyzers if not __has_enabled_checker(config_map[a])] | ||
| for analyzer in no_checker_analyzers: | ||
| LOG.info("No checkers enabled for %s", analyzer) |
There was a problem hiding this comment.
Can we tell if the user explicitly enabled an analyzer? If so, we should hard error, shouldn't we?
There was a problem hiding this comment.
I can be convinced, but I would feel a hard error a little strong here.
There was a problem hiding this comment.
I'll give you that one.
Add --disable-all flag which disables all checkers of all analyzers. It is equilent to using "--disable default".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes users want to execute exactly one checker. This can be done by disabling all checkers and then enabling that one. Some analyzers fail if no checker is enabled. For example, if the user wants to enable one ClangSA checker and disable everything else explicitly, then ClangTidy fails.
After this patch an analyzer will not be triggered if all of its checkers are disabled.
[cmd] Add --disable-all flag
Add --disable-all flag which disables all checkers of all analyzers. It
is equilent to using "--disable default".
Should be merged after #3949.